removed react peer dependency, upgraded to new react and helpers version #25
Conversation
| @@ -28,9 +28,6 @@ | |||
| "email": "[email protected]" | |||
| }, | |||
| "main": "dist/react-json-editor.js", | |||
| "peerDependencies": { | |||
| "react": ">=0.12.2 <1.0.0" | |||
| }, | |||
There was a problem hiding this comment.
I think we should go with "react": "^0.14.0 || ^15.0.0" instead of removing it completely.
There was a problem hiding this comment.
@ismaelga ok, can I ask why we need a peer dependency? Is it due to lumc-nested/nested-editor#54?
Do we use lumc-nested/nested-editor?
Overall I love this project by the way. Very comprehensive.
There was a problem hiding this comment.
@newbreedofgeek Projects using react-json-editor will already have their own React and this module will need to support that version rather than use its own. Hence it's a peer dependency.
Also it avoids having multiple versions of the same module being bundled in the same project.
There was a problem hiding this comment.
@jahed Ack on the peer dependency. Whats the status of this? I'm from the https://github.com/lumc-nested/nested-editor team as referenced above and we would like to move to React 15.
There was a problem hiding this comment.
@marksantcroos I ended up dropping my dependency on this project. Though, last I checked, the change @ismaelga suggested worked fine, so you can probably fork the repo, make the change and use the fork. Or submit a PR and hope this repo is still being maintained.
There was a problem hiding this comment.
Hi guys! I haven't given the proper attention to this repo since I don't use it anymore and also because there is a great alternative now https://github.com/mozilla-services/react-jsonschema-form
That said. I will try to give attention to the open issues some day soon. And make sure it works with latest React version
|
No need for this anymore. Thanks |
related to #24
I've done some tests and the core feature set seems to work with react 15.0.2.
So I migrated all core react and react-tools to this version, removed peer dependency and made minor changes to react render for it to work. Also ignoring node_modules which should not be transpiled.