Refactor surrounding MxDSChunk
utility functions
#1313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically: the functions
IntoType
andIntoLength
from theMxDSChunk
header. They seek a pointer into the right place when reading the chunk, but the beta shows they are not used. TheSize
andEnd
functions are used, but they are different from what we had.These two functions are users of the utility functions:
MxDiskStreamProvider::FUN_100d1b20
now 100%ReadData
(fromMxRAMStreamProvider
) still 100% but with entropyI'm not sure why, but this has also caused us to jump from 141 to 432 functions aligned. It may just be chance, but these two runs of functions now line up: