Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor surrounding MxDSChunk utility functions #1313

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

disinvite
Copy link
Collaborator

Specifically: the functions IntoType and IntoLength from the MxDSChunk header. They seek a pointer into the right place when reading the chunk, but the beta shows they are not used. The Size and End functions are used, but they are different from what we had.

These two functions are users of the utility functions:

  • MxDiskStreamProvider::FUN_100d1b20 now 100%
  • ReadData (from MxRAMStreamProvider) still 100% but with entropy

I'm not sure why, but this has also caused us to jump from 141 to 432 functions aligned. It may just be chance, but these two runs of functions now line up:

0001:0000b110          0  fun  103     MxEntity::~MxEntity
to
0001:00012c40          0  fun  458     LegoJetski::HitActor

and

0001:00016650          0  fun  390     CarRace::HandleClick
to
0001:00016da0          0  fun  215     PizzeriaState::Serialize

@foxtacles
Copy link
Member

I'm not sure why, but this has also caused us to jump from 141 to 432 functions aligned. It may just be chance, but these two runs of functions now line up:

0001:0000b110          0  fun  103     MxEntity::~MxEntity
to
0001:00012c40          0  fun  458     LegoJetski::HitActor

and

0001:00016650          0  fun  390     CarRace::HandleClick
to
0001:00016da0          0  fun  215     PizzeriaState::Serialize

Probably entropy, but looks good!

@foxtacles foxtacles merged commit 93815ca into isledecomp:master Jan 6, 2025
12 checks passed
@disinvite disinvite deleted the pr-chunk-header branch January 6, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants