Adapt short wavelength filter to use gdal_fillnodata to mitigate edge effects
#520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI error is a temporary problem with dependency version mismatches conda-forge/jaxlib-feedstock#296 |
seyeonjeon
reviewed
Jan 10, 2025
|
|
||
| filtered_ifg = unw_ifg_interp - lowpass_filtered * in_bounds_pixels | ||
| filtered_ifg = filled_data - lowpass_filtered * in_bounds_pixels |
There was a problem hiding this comment.
If 'None', it gives:
Should we do like this?
filtered_ifg = (filled_data - lowpass_filtered) * in_bounds_pixels
This one gives:
There was a problem hiding this comment.
ah good catch! Weird that it ever worked for me...
seyeonjeon
reviewed
Jan 10, 2025
| @@ -42,6 +45,9 @@ def filter_long_wavelength( | |||
| Value to place in output pixels which were masked. | |||
| If `None`, masked pixels are filled with the ramp value fitted | |||
There was a problem hiding this comment.
We are not fitting ramp anymore.
Should we say like this?
If 'None', masked pixels are filled with interpolated values using 'gdal_fillnodata'.
scottstanie
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Update filtering.py * Update filtering.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on a horizontal ramp:
the main branch leaves an edge effect:
This PR gives all zeros, as we would want.
Sanity check on small, real unwrapping interferogram looks okay as well.
