Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed boolean in config example #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tuxjz
Copy link

@tuxjz tuxjz commented Jun 24, 2022

Kea config example contains invalid definition of boolean:

# kea-dhcp6 -t /etc/kea/kea-dhcp6.conf
Syntax check failed with: /etc/kea/kea-dhcp6.conf:169.27-32: syntax error, unexpected constant string, expecting boolean
# kea-dhcp4 -t kea-dhcp4.conf 
Syntax check failed with: kea-dhcp4.conf:142.27-32: syntax error, unexpected constant string, expecting boolean

@pdostal
Copy link

pdostal commented Sep 3, 2024

Hi, seem this is just mirror, they have internal GitLab. From CONTRIBUTING.md:

Here's a quick list of how to contribute a patch:

  • create account on gitlab
  • open an issue in Kea project, make sure it describes what you want to fix and why
  • ask someone from the ISC team to give you permission to fork Kea (ask @tomek, @vicky, @ondrej or basically anyone from the Kea dev team)
  • fork Kea code: go to Kea project page, click Fork button. If you can't, you didn't complete step 3.
  • Implement your fix or feature, push code to your repo. Make sure it compiles, has unit-tests, is documented and does what it's supposed to do.
  • Open Merge Request: go to Kea project merge requests page, click New merge request. If you don't see the button, you didn't complete step 3.
  • Participate in the code review: Once you submit the MR, someone from ISC will eventually get to the issue and will review your code. Please make sure you respond to comments. It's likely you'll be asked to update the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants