[#2022] Added a comment about yhe unparking race

isc-projects · Feb 23, 2024 · 03e7646 · 03e7646
1 parent 8f254fb
commit 03e7646
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/bin/dhcp4/dhcp4_srv.cc b/src/bin/dhcp4/dhcp4_srv.cc
@@ -752,6 +752,8 @@ Dhcpv4Srv::selectSubnet(const Pkt4Ptr& query, bool& drop,
                                     getCfgSubnets4()->getAll());
 
         // We proactively park the packet.
+        // Not MT compatible because the unparking callback can be called
+        // before the current thread exists from this block.
         HooksManager::park("subnet4_select", query,
                            [this, query, allow_answer_park] () {
                                processLocalizedQuery4AndSendResponse(query,
@@ -897,6 +899,8 @@ Dhcpv4Srv::selectSubnet4o6(const Pkt4Ptr& query, bool& drop,
                                     getCfgSubnets4()->getAll());
 
         // We proactively park the packet.
+        // Not MT compatible because the unparking callback can be called
+        // before the current thread exists from this block.
         HooksManager::park("subnet4_select", query,
                            [this, query, allow_answer_park] () {
                                processLocalizedQuery4AndSendResponse(query,

diff --git a/src/bin/dhcp6/dhcp6_srv.cc b/src/bin/dhcp6/dhcp6_srv.cc
@@ -2017,6 +2017,8 @@ Dhcpv6Srv::selectSubnet(const Pkt6Ptr& question, bool& drop) {
                                     getCfgSubnets6()->getAll());
 
         // We proactively park the packet.
+        // Not MT compatible because the unparking callback can be called
+        // before the current thread exists from this block.
         HooksManager::park("subnet6_select", question,
                            [this, question] () {
                                processLocalizedQuery6AndSendResponse(question);