[mdbx_sys] README.md and build.rs to fix Windows build #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psengrith
changed the title
|
@vicenterusso Do you have an idea why the github action workflow did not build this pull request? |
No clue, maybe because it was marked as a draft? just guessing.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following files in the mdbx_sys package:
README.mdwhich explains steps to properly build the package on Windows for Rust Development.build.rsto fix build errors on Windows: Specifically, the new script introduces workarounds to solve:bindgenincompatibility withclang(#2500), and-D MDBX_LOCK_SUFFIXwas properly configured for Windows build through CMake. This could potentially result in undefined behavior in Windows since the isar logic (e.g.,IsarInstance::close_internal) is hard-coded to depend on the suffix.lock.Note: This an updated pull request of the amended #87 (because directory structure mistake)