-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not depend on deprecated 'constants' module #206
base: main
Are you sure you want to change the base?
Conversation
9f7b7c4
to
45e62bd
Compare
Co-authored-by: Corey Farrell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing a lot of issues for me. @isaacs Please take a look
|
@isaacs Would be great if you could take a look at this. As per https://nodejs.org/api/deprecations.html#DEP0008
|
constants
module has been deprecated since v6.3.0 (ref: https://nodejs.org/api/deprecations.html#DEP0008 ). This PR updates the use ofconstants
tofs.constants
.BTW
fs.constants
doesn't inherit from Object.prototype (ref: nodejs/node#10458 ), so I updatedconstants.hasOwnProperty('O_SYMLINK')
toconstants.O_SYMLINK !== undefined
. (This change was discussed in node.js repository nodejs/node#10458 (comment) )