Improved workarounds for win32, continued#131

Open

jgoz wants to merge 23 commits intoisaacs:mainfrom jgoz:win32-rename-override

+220-41

Commits on Jul 19, 2019

Stat from file to make sure it was renamed

mekwall
authored and
jgoz
committed
Resolve if source and destination is the same size

mekwall
authored and
jgoz
committed
Except rename to not return an error

mekwall
authored and
jgoz
committed
Unlink source if it's the same as destination

mekwall
authored and
jgoz
committed
Do not unlink file

mekwall
authored and
jgoz
committed
Add fs.renameSync for win32

mekwall
authored and
jgoz
committed
Remove extraneous line

mekwall
authored and
jgoz
committed
Improve stat compare between src and dest

mekwall
authored and
jgoz
committed
Ignore ENOENT for src on retry

mekwall
authored and
jgoz
committed
Wait until dest exist and src does not

mekwall
authored and
jgoz
committed
Revamped rename tests

mekwall
authored and
jgoz
committed
Remove sneaky arrow functions

mekwall
authored and
jgoz
committed
Updated comments and formatting

mekwall
authored and
jgoz
committed
Assume rename was successful if source no longer exists

mekwall
authored and
jgoz
committed
Make sure both statFrom and statTo are set

mekwall
authored and
jgoz
committed
Add additional comment about size/ctime comparison

mekwall
authored and
jgoz
committed
Unlink target it if exists

mekwall
authored and
jgoz
committed
Add test for renaming dirs

mekwall
authored and
jgoz
committed
Reduce backoff to 5s, make configurable via env
jgoz
committed
Guard cb calls
jgoz
committed
Ensure teardownDirs is called appropriately
jgoz
committed
Respect ENOTEMPTY errors from rmdir
jgoz
committed
Formatting
jgoz
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved workarounds for win32, continued#131

Commits on Jul 19, 2019

Stat from file to make sure it was renamed

Resolve if source and destination is the same size

Except rename to not return an error

Unlink source if it's the same as destination

Do not unlink file

Add fs.renameSync for win32

Remove extraneous line

Improve stat compare between src and dest

Ignore ENOENT for src on retry

Wait until dest exist and src does not

Revamped rename tests

Remove sneaky arrow functions

Updated comments and formatting

Assume rename was successful if source no longer exists

Make sure both statFrom and statTo are set

Add additional comment about size/ctime comparison

Unlink target it if exists

Add test for renaming dirs

Reduce backoff to 5s, make configurable via env

Guard cb calls

Ensure teardownDirs is called appropriately

Respect ENOTEMPTY errors from rmdir

Formatting