Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebusy retry #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ebusy retry #128

wants to merge 2 commits into from

Conversation

conceptualspace
Copy link

@conceptualspace conceptualspace commented May 3, 2018

win32: retry rename on EBUSY, as we do for EPERM and EACCESS

EBUSY can occur when resources are locked by applications (ex. Dropbox, AV). it seems sensible to retry in this scenario too. the proposed behavior is consistent with rimraf (https://github.com/isaacs/rimraf)

resolves #127

when rename fails with EBUSY we should also retry like we do with EPERM and EACCESS

behaviour is consistent with rm (https://github.com/isaacs/rimraf)

resolves isaacs#127
@Toilal
Copy link

Toilal commented Dec 5, 2018

Would you consider merging this pull request ? I'm getting warning because of this issue when running npm install over a NFS share.

@mbargiel
Copy link

mbargiel commented Nov 2, 2022

@isaacs Say, while this PR is no longer mergeable and has no tests, the fix it implements actually solves a problem we've run into on 4.2.8. Would you accept a "respin" of this PR if I contributed one? I would reapply this fix on top of the current implementation + provide test coverage.

@zkochan
Copy link

zkochan commented Apr 4, 2023

This one was fixed: #127

@mbargiel
Copy link

mbargiel commented Apr 4, 2023

Thanks for the info @zkochan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should rename account for 'EBUSY' on Windows?
4 participants