Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved workarounds for win32 #119

Closed
wants to merge 18 commits into from
+3,643 −39
Closed

Improved workarounds for win32 #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
14bb35a
Stat from file to make sure it was renamed
mekwall Oct 10, 2017
ecbebd8
Resolve if source and destination is the same size
mekwall Oct 10, 2017
92dd004
Except rename to not return an error
mekwall Oct 10, 2017
c2831ea
Unlink source if it's the same as destination
mekwall Oct 10, 2017
5d39057
Do not unlink file
mekwall Oct 11, 2017
2528177
Add fs.renameSync for win32
mekwall Oct 11, 2017
4882f5d
Remove extraneous line
mekwall Oct 11, 2017
6e491f5
Improve stat compare between src and dest
mekwall Oct 11, 2017
4ddb118
Ignore ENOENT for src on retry
mekwall Oct 11, 2017
f7f1d95
Wait until dest exist and src does not
mekwall Oct 11, 2017
b564fd9
Revamped rename tests
mekwall Oct 11, 2017
3c4e270
Remove sneaky arrow functions
mekwall Oct 11, 2017
625f52b
Updated comments and formatting
mekwall Oct 12, 2017
1b41578
Assume rename was successful if source no longer exists
mekwall Oct 12, 2017
641fa52
Make sure both statFrom and statTo are set
mekwall Nov 7, 2017
516fa6c
Add additional comment about size/ctime comparison
mekwall Nov 7, 2017
78f7a5b
Unlink target it if exists
mekwall Nov 10, 2017
a10aa57
Add test for renaming dirs
mekwall Nov 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading