New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 37 #43

Open

jferard wants to merge 2 commits into iryndin:master from jferard:issue_37

Contributor

jferard commented Mar 2, 2018

I summarize what issue 37 is. When reading a Memo file, the current code tries to emulate a random access with the following method:

mark the stream (8192 bytes) once
for each read:
- reset the stream
- skip n bytes
- read k bytes.

This method is fragile:

the mark may be insufficient
"InputStream.skip() method may skip fewer bytes than requested" (pointed by wescleveland56)

We need a real random access, but with a low memory footprint (= without loading the whole file in memory: see issue #5 and commit d99575c) and with a good speed. This PR proposes to use a MappedByteBuffer (see https://www.codeproject.com/Tips/683614/10-Things-to-Know-about-Memory-Mapped-File-in-Java) to let the OS deal with the disk accesses, rather than a plain RandomAccessFile.

Note 1: no speed tests made.
Note 2: I updated .gitignore to remove noise from Eclipse or Intellij...

jferard added 2 commits

March 2, 2018 23:22


          Add eclipse and intellij config files to .gitignore

9eed844


          Make MemoReader use a MappedByteBuffer instead of the poor man's random

dc2785c

access (mark/reset/skip).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet