Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mount Action and Tagger {#} #834

Open
fedeicodip opened this issue Sep 9, 2024 · 7 comments
Open

[BUG] Mount Action and Tagger {#} #834

fedeicodip opened this issue Sep 9, 2024 · 7 comments

Comments

@fedeicodip
Copy link

Using the mount trigger action (with rideable), the {#} wildcard code (used by tagger to generate an unique variable identifier) isn't parsed and translated to a single number when a tile is placed on the scene. The mount action code remains pointing to a xxxyyyzzz-{#} tag that isn't pointing to anywhere (while the tile tag is translated as expected).

Side note: Rideable is configured to use tiles as rideable entities

@fedeicodip fedeicodip changed the title Mount Action and Tagger {#} [BUG] Mount Action and Tagger {#} Sep 9, 2024
@Crowguard
Copy link

@fedeicodip You should log with Rideable; its the one adding all the code for those actions.

@Saibot393
Copy link

Saibot393 commented Sep 18, 2024

I tried replicating the bug but had so far no success, just to make sure, that we are using the same conditions, are you using a MATT tile template or a token attached template?
Scratch that, sorry, tried it with the wrong field

@fedeicodip
Copy link
Author

fedeicodip commented Sep 18, 2024

Thank you, let me know if I can help

@Saibot393
Copy link

Saibot393 commented Sep 18, 2024

I have found another core MATT field that behaves the same way, the "token" field of the "Reset Tile trigger history" action will also not update the {#} correctly when placed. From what i can tell, MATT will only apply the "{#}" counter to data fields that are named one of these: "entity", "location", "position".
I was however so far not able to locate the exact part of the code that will update the tags. I also don't think that there is a lot i can do on my end, sorry.

@Crowguard
Copy link

No problem; thanks for looking Saibot. Will have to just wait & see Ironmonk says I guess.

@Saibot393
Copy link

Saibot393 commented Sep 20, 2024

So, i had another look and figured out why i couldn't find the part of the code that takes care of the {#}. It seems like tagger itself is at fault here as it only takes entity and location fields into consideration when updating tags

@Saibot393
Copy link

I have created a PR for Tagger that should solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants