Expose a generic read method that can be extended #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapters included for S3 files and files available over http(s)
Instantiating a new client blocks on retrieving filesize. But there are cases when we really don't need the filesize, for example when we have the metadata cached already.
…l over how the `readFn` is called, for example concurrency limits or combination of requests that are close in offsets
ZJONSSON
force-pushed
the
readfn-wrapper
branch
from
ec70018 to
f82f719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to have more control over how the
readFnis called, for example concurrency limits or combination of requests that are close in offsets