Merge pull request #37 from ZJONSSON/optional-undefined

Don't error if an optional value is `undefined` or `null`
ironSource · Feb 11, 2018 · 1fa58b5 · 1fa58b5
2 parents 57ebf09 + 50243bb
commit 1fa58b5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/shred.js b/lib/shred.js
@@ -79,7 +79,7 @@ function shredRecordInternal(fields, record, data, rlvl, dlvl) {
 
     // fetch values
     let values = [];
-    if (record && (fieldName in record)) {
+    if (record && (fieldName in record) && record[fieldName] !== undefined && record[fieldName] !== null) {
       if (record[fieldName].constructor === Array) {
         values = record[fieldName];
       } else {

diff --git a/test/integration.js b/test/integration.js
@@ -68,6 +68,7 @@ function mkTestRows(opts) {
     rows.push({
       name: 'kiwi',
       price: 4.2,
+      quantity: undefined,
       day: new Date('2017-11-26'),
       date: new Date(TEST_VTIME + 8000 * i),
       finger: "FNORD",