Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pw/chen #300

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

Pw/chen #300

wants to merge 79 commits into from

Conversation

bar-unity
Copy link
Collaborator

No description provided.

bar-unity and others added 30 commits March 21, 2024 15:12
@bar-unity
chore(demand_style_e2e): 1. add test id to constructor
139e3a2 
                         2. each component should extend base component
                         3. base component should extend base element
@bar-unity
chore(demand_style_e2e): fix alert constructor
54009a3
@bar-unity
Merge branch 'release/6.x.x' into demand_style_e2e
2cc737d
@bar-unity
chore(ISCT-291): use base wrapped methods
3f43684
@bar-unity
chore(ISCT-291): improve code
4dc7dc7
@bar-unity
chore(ISCT-291): remove PW import in alert component
9a097f7
@bar-unity
chore(ISCT-291): fix also button component
d22473d
@bar-unity
chore(demand_style_e2e): change ComponentBasePage to BasePage
025b4d0
@bar-unity
chore(demand_style_e2e): move pages to different folder
f4782fa
@bar-unity
chore(demand_style_e2e): fix more components
a3b4da3
@bar-unity
chore(demand_style_e2e): fix input components
210c81a
@bar-unity
chore(demand_style_e2e): fix more components
6c70af8
@bar-unity
chore(demand_style_e2e): use just base component functions
d13da3e
@bar-unity
chore(demand_style_e2e): use just base component functions
0c63852
@bar-unity
chore(demand_style_e2e): improve naming
88acc19
@bar-unity
chore(demand_style_e2e): improve button-component.ts
950a443
@bar-unity
chore(demand_style_e2e): improve chart-component.ts
c8a0b87
@bar-unity
chore(demand_style_e2e): fix cr comment and add elements folder
5e9e17b
@bar-unity
chore(demand_style_e2e): remove "waitForComponent" from all component…
9c5491e 
…, and move it to base
@bar-unity
chore(demand_style_e2e): added return type for methods
19cbde7
@bar-unity
chore(demand_style_e2e): make properties public
4c83aba
chore(release): 6.5.5-rc.9
469400e
@bar-unity
chore(demand_style_e2e): fix const.ts
a0842fa
@bar-unity
chore(demand_style_e2e): move tests to separate file
482958a
@bar-unity
chore(demand_style_e2e): change 'component' to relevant entity name
c5381d9
@bar-unity
chore(demand_style_e2e): use getLocator from base in button-component.ts
4488b85
@bar-unity
chore(demand_style_e2e): improve all components readability and added…
2b23810 
… typing
@bar-unity
revert unneeded change
98d6c5f
@bar-unity
chore(demand_style_e2e): revert unneeded changes
f6a62f1
@bar-unity
Merge remote-tracking branch 'origin/demand_style_e2e' into demand_st…
df93e87 
…yle_e2e
@bar-unity bar-unity requested a review from AndyKIron April 15, 2024 12:06
AndyKIron
AndyKIron approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@AndyKIron AndyKIron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes on "projects/fusion-ui" approved

projects/fusion-ui/components/chart-labels/v4/chart-labels-v4.component.ts Outdated Show resolved Hide resolved
NoaMartan
NoaMartan suggested changes Apr 16, 2024
View reviewed changes
projects/fusion-e2e/entities/tests/include-exclude/include-exclude.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/tests/inputs/base-input.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/tests/chart/chart.pw.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/tests/chart/chart.pw.ts Show resolved Hide resolved
projects/fusion-e2e/entities/tests/chart/chartLabelIcon.pw.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/tests/chart/chartLabelIcon.pw.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/components/chip-filter/chipFilter-component.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/components/chip-filter/chipFilter-component.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/tests/chart/chartLabelIcon.pw.ts Show resolved Hide resolved
NoaMartan
NoaMartan reviewed Apr 18, 2024
View reviewed changes
projects/fusion-e2e/entities/components/inputs/base-input.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/components/inputs/base-input.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/alert-page.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/button-page.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/button-page.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/button-page.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/chart-page.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/chipFilter-page.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/tabs-page.ts Outdated Show resolved Hide resolved
projects/fusion-e2e/entities/pages/trend-indicator-page.ts Outdated Show resolved Hide resolved
@bar-unity bar-unity requested a review from NoaMartan April 18, 2024 11:30
bar-unity and others added 6 commits April 18, 2024 15:50
@bar-unity
chore(fix): fix CR comment
d1fd99e
@bar-unity
Merge branch 'refs/heads/release/8.x.x' into pw/chen
0392a07 
# Conflicts:
#	package-lock.json
#	projects/fusion-ui/components/chart-labels/v4/chart-labels-v4.component.html
#	projects/fusion-ui/components/chart-labels/v4/chart-labels-v4.component.ts
#	projects/fusion-ui/components/chart/v4/stories/chart-v4-story-wrapper.component.ts
@bar-unity
chore(fix): fix import
66f9f48
@AndyKIron
chore: set test version
24da38d
@bar-unity
Merge branch 'refs/heads/release/8.x.x' into pw/chen
0f024ad 
# Conflicts:
#	package-lock.json
@AndyKIron
Merge branch 'refs/heads/release/8.x.x' into pw/chen
5eb779f 
# Conflicts:
#	package-lock.json
#	package.json
#	projects/fusion-ui/package.json
Base automatically changed from release/8.x.x to master May 15, 2024 07:08
@AndyKIron AndyKIron changed the base branch from master to release/8.x.x June 5, 2024 07:11
Base automatically changed from release/8.x.x to master July 7, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyKIron AndyKIron AndyKIron approved these changes

@NoaMartan NoaMartan Awaiting requested review from NoaMartan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bar-unity @AndyKIron @NoaMartan @chenlevin89