ISCT-97: Add UI style v4 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/isct-97-ui-style-v4
…book-foundation folder by version v3 and v4 as sub-folders
Remove section of icons from V4 root folder - they are from phosphor icons lib
…o feature/isct-97-ui-style-v4
…on component consumer no need use full path "ph/regular/some-icon" fro regular icons, instead possible to use "ph/regular/some-icon"
chenlevin89
requested changes
Nov 16, 2023
| @@ -37,6 +37,7 @@ export class IconDocsV2Component implements OnInit { | |||
|
|
|||
| private getIcons$(): Observable<string[]> { | |||
| const iconNames$ = of(ICON_NAMES); // possible from API service | |||
| // const iconNames$ = of( Array(1000).fill('analytics') /*ICON_NAMES.filter(icon=>icon==='analytics')*/); // possible from API service | |||
| @@ -56,35 +59,49 @@ export class SvgComponent implements AfterViewInit, OnDestroy { | |||
| } | |||
|
|
|||
| ngAfterViewInit() { | |||
| this.loadSvg(); | |||
| if (!this.requestedToLoad) { | |||
There was a problem hiding this comment.
why do you need this requestedToLoad ?
There was a problem hiding this comment.
Because has 2 call for this.loadSvg();
One from ngAfterViewInit() - after element will be rendered, and also has in onPathChanged method.
But now we don't need it (http request now shared)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.