chore(isct-63): add attribution to table, table row, search, modal

ironSource · Oct 16, 2023 · e217068 · e217068
1 parent 68c9844
commit e217068
Show file tree

Hide file tree

Showing 22 changed files with 131 additions and 20 deletions.
diff --git a/projects/fusion-ui/components/chip-filter/common/base/chip-filter.base.component.ts b/projects/fusion-ui/components/chip-filter/common/base/chip-filter.base.component.ts
@@ -31,6 +31,7 @@ import {TestIdsService} from '@ironsource/fusion-ui/services/test-ids';
 
 @Directive()
 export abstract class ChipFilterBaseComponent implements OnInit, AfterViewInit, OnDestroy, AfterContentInit {
+    /** @internal */
     @Input() testId: string;
     /** @internal */
     @ContentChild(ApiBase, {static: true}) apiBase: ApiBase;
@@ -52,7 +53,9 @@ export abstract class ChipFilterBaseComponent implements OnInit, AfterViewInit,
     /** @internal */
     rightIcon: ChipIcon;
 
+    /** @internal */
     testIdChipFilterModifiers: typeof ChipFilterTestIdModifiers = ChipFilterTestIdModifiers;
+    /** @internal */
     testIdsService: TestIdsService = this.injector.get(TestIdsService);
 
     private onDestroy$ = new Subject<void>();

diff --git a/...nents/dropdown-dual-multi-select/common/base/dropdown-dual-multi-select.base.component.ts b/...nents/dropdown-dual-multi-select/common/base/dropdown-dual-multi-select.base.component.ts
@@ -46,6 +46,7 @@ export abstract class DropdownDualMultiSelectBaseComponent extends ApiBase imple
     /** @internal */
     @Input() autoComplete: boolean = true;
     @Input() title: string;
+    /** @internal */
     @Input() testId: string;
     /** @internal */
     @Input() pendingItems: boolean = false;
@@ -59,7 +60,9 @@ export abstract class DropdownDualMultiSelectBaseComponent extends ApiBase imple
         return this._hasSelectAll;
     }
 
+    /** @internal */
     testIdIncludeExcludeModifiers: typeof IncludeExcludeTestIdModifiers = IncludeExcludeTestIdModifiers;
+    /** @internal */
     testIdsService: TestIdsService = this.injector.get(TestIdsService);
 
     @Input() set placeholder(data: string) {

diff --git a/...2/components/dropdown-dual-multi-select-body/dropdown-dual-multi-select-body.component.ts b/...2/components/dropdown-dual-multi-select-body/dropdown-dual-multi-select-body.component.ts
@@ -46,6 +46,7 @@ export class DropdownDualMultiSelectBodyComponent implements OnInit, OnDestroy,
     @Input() totalItems: number;
     @Input() isPendingItems: boolean;
     @Input() hasSelectAll: boolean = true;
+    /** @internal */
     @Input() testId: string;
 
     @Input() set items(data: DropdownOption[]) {

diff --git a/...mponents/dropdown-dual-multi-select-footer/dropdown-dual-multi-select-footer.component.ts b/...mponents/dropdown-dual-multi-select-footer/dropdown-dual-multi-select-footer.component.ts
@@ -7,6 +7,7 @@ import {ChangeDetectionStrategy, Component, EventEmitter, Input, Output} from '@
     changeDetection: ChangeDetectionStrategy.OnPush
 })
 export class DropdownDualMultiSelectFooterComponent {
+    /** @internal */
     @Input() testId: string;
     @Output() applySelect = new EventEmitter<boolean>();
     @Output() closeSelect = new EventEmitter();

diff --git a/...mponents/dropdown-dual-multi-select-header/dropdown-dual-multi-select-header.component.ts b/...mponents/dropdown-dual-multi-select-header/dropdown-dual-multi-select-header.component.ts
@@ -19,6 +19,7 @@ import {Subject} from 'rxjs';
 })
 export class DropdownDualMultiSelectHeaderComponent implements OnDestroy, ControlValueAccessor {
     @Input() title: string;
+    /** @internal */
     @Input() testId: string;
 
     inputSize = InputSize;

diff --git a/...dy/dropdown-dual-multi-select-body-item/dropdown-dual-multi-select-body-item.component.ts b/...dy/dropdown-dual-multi-select-body-item/dropdown-dual-multi-select-body-item.component.ts
@@ -14,12 +14,15 @@ export class DropdownDualMultiSelectBodyItemComponent {
     @Input() item: DropdownOption;
     @Input() isDisabled: boolean;
     @Input() isSelectedItem: boolean;
+    /** @internal */
     @Input() testId: string;
 
     @Output() changeSelected = new EventEmitter();
     @Output() clearSelect = new EventEmitter();
 
+    /** @internal */
     testIdIncludeExcludeModifiers: typeof IncludeExcludeTestIdModifiers = IncludeExcludeTestIdModifiers;
+    /** @internal */
     testIdsService: TestIdsService = this.injector.get(TestIdsService);
 
     constructor(private injector: Injector) {}

diff --git a/...3/components/dropdown-dual-multi-select-body/dropdown-dual-multi-select-body.component.ts b/...3/components/dropdown-dual-multi-select-body/dropdown-dual-multi-select-body.component.ts
@@ -50,6 +50,7 @@ export class DropdownDualMultiSelectBodyComponent implements OnInit, OnDestroy,
     @Input() totalItems: number;
     @Input() isPendingItems: boolean;
     @Input() hasSelectAll: boolean = true;
+    /** @internal */
     @Input() testId: string;
 
     @Input() set items(data: DropdownOption[]) {
@@ -75,7 +76,9 @@ export class DropdownDualMultiSelectBodyComponent implements OnInit, OnDestroy,
 
     @Output() scrollDown = new EventEmitter();
 
+    /** @internal */
     testIdIncludeExcludeModifiers: typeof IncludeExcludeTestIdModifiers = IncludeExcludeTestIdModifiers;
+    /** @internal */
     testIdsService: TestIdsService = this.injector.get(TestIdsService);
 
     isSelectAllDisabled$ = new BehaviorSubject<boolean>(false);

diff --git a/...mponents/dropdown-dual-multi-select-footer/dropdown-dual-multi-select-footer.component.ts b/...mponents/dropdown-dual-multi-select-footer/dropdown-dual-multi-select-footer.component.ts
@@ -9,11 +9,14 @@ import {TestIdsService} from '@ironsource/fusion-ui/services/test-ids';
     changeDetection: ChangeDetectionStrategy.OnPush
 })
 export class DropdownDualMultiSelectFooterComponent {
+    /** @internal */
     @Input() testId: string;
     @Output() applySelect = new EventEmitter<boolean>();
     @Output() closeSelect = new EventEmitter();
 
+    /** @internal */
     testIdIncludeExcludeModifiers: typeof IncludeExcludeTestIdModifiers = IncludeExcludeTestIdModifiers;
+    /** @internal */
     testIdsService: TestIdsService = this.injector.get(TestIdsService);
 
     constructor(private injector: Injector) {}

diff --git a/...mponents/dropdown-dual-multi-select-header/dropdown-dual-multi-select-header.component.ts b/...mponents/dropdown-dual-multi-select-header/dropdown-dual-multi-select-header.component.ts
@@ -33,9 +33,12 @@ export class DropdownDualMultiSelectHeaderComponent implements OnDestroy, AfterV
     @ViewChild('input') input?: ElementRef;
 
     @Input() title: string;
+    /** @internal */
     @Input() testId: string;
 
+    /** @internal */
     testIdIncludeExcludeModifiers: typeof IncludeExcludeTestIdModifiers = IncludeExcludeTestIdModifiers;
+    /** @internal */
     testIdsService: TestIdsService = this.injector.get(TestIdsService);
 
     searchIcon?: IconData = {iconName: 'search-bold', iconVersion: 'v3'};

diff --git a/projects/fusion-ui/components/modal/v3/components/modal-footer/modal-footer.component.ts b/projects/fusion-ui/components/modal/v3/components/modal-footer/modal-footer.component.ts
@@ -1,5 +1,6 @@
 import {Component, EventEmitter, Injector, Input, Output} from '@angular/core';
-import {ModalTestIdModifiers, TestIdsService} from '@ironsource/fusion-ui';
+import {ModalTestIdModifiers} from '@ironsource/fusion-ui/entities';
+import {TestIdsService} from '@ironsource/fusion-ui/services/test-ids';
 
 @Component({
     selector: 'fusion-modal-footer',
@@ -19,6 +20,7 @@ export class ModalFooterComponent {
         this.submitButtonDisabled = config?.submitButtonDisabled;
     }
     @Input() error;
+    /** @internal */
     @Input() testId: string;
 
     @Output() onSubmit = new EventEmitter();

diff --git a/projects/fusion-ui/components/modal/v3/components/modal-header/modal-header.component.ts b/projects/fusion-ui/components/modal/v3/components/modal-header/modal-header.component.ts
@@ -1,6 +1,6 @@
 import {Component, EventEmitter, Injector, Input, Output} from '@angular/core';
-import {BehaviorSubject} from 'rxjs';
-import {ModalTestIdModifiers, TestIdsService} from '@ironsource/fusion-ui';
+import {ModalTestIdModifiers} from '@ironsource/fusion-ui/entities';
+import {TestIdsService} from '@ironsource/fusion-ui/services/test-ids';
 
 @Component({
     selector: 'fusion-modal-header',
@@ -10,6 +10,7 @@ import {ModalTestIdModifiers, TestIdsService} from '@ironsource/fusion-ui';
 export class ModalHeaderComponent {
     @Input() headerText: string;
     @Input() showCloseButton = true;
+    /** @internal */
     @Input() testId: string;
 
     private _infoText: string;

diff --git a/projects/fusion-ui/components/modal/v3/modal.component.ts b/projects/fusion-ui/components/modal/v3/modal.component.ts
@@ -58,7 +58,7 @@ export class ModalComponent implements OnDestroy, OnInit {
     get configuration(): ModalConfiguration {
         return this._configuration.getValue();
     }
-
+    /** @internal */
     @Input() testId: string;
 
     @Output() open = new EventEmitter();
@@ -69,7 +69,9 @@ export class ModalComponent implements OnDestroy, OnInit {
     /** @internal */
     @ViewChild('modalHolder', {static: true}) modalHolder: ElementRef;
 
+    /** @internal */
     modalTestIdModifiers: typeof ModalTestIdModifiers = ModalTestIdModifiers;
+    /** @internal */
     testIdsService: TestIdsService = this.injector.get(TestIdsService);
 
     private uid: string;

diff --git a/projects/fusion-ui/components/search/v3/search.component.html b/projects/fusion-ui/components/search/v3/search.component.html
@@ -6,5 +6,11 @@
        [placeholder]="placeholder"
        [formControl]="searchFormControl"
        [class.fu-has-clear-icon]="showClearIcon"
+       [attr.data-testid]="testIdsService.getTestAttribute.bind(this) | generic:testId:searchTestIdModifiers.INPUT"
 />
-<fusion-icon class="fu-clear" *ngIf="showClearIcon && (searchFormControl.valueChanges | async)" [name]="clearIcon" (click)="clearInput(true)"></fusion-icon>
+<fusion-icon class="fu-clear"
+             *ngIf="showClearIcon && (searchFormControl.valueChanges | async)"
+             [name]="clearIcon"
+             [attr.data-testid]="testIdsService.getTestAttribute.bind(this) | generic:testId:searchTestIdModifiers.CLEAR_BUTTON"
+             (click)="clearInput(true)"
+></fusion-icon>
diff --git a/projects/fusion-ui/components/search/v3/search.component.ts b/projects/fusion-ui/components/search/v3/search.component.ts
@@ -1,18 +1,21 @@
-import {ChangeDetectionStrategy, Component, ElementRef, forwardRef, Input, OnDestroy, OnInit, ViewChild} from '@angular/core';
+import {ChangeDetectionStrategy, Component, ElementRef, forwardRef, Injector, Input, OnDestroy, OnInit, ViewChild} from '@angular/core';
 import {CommonModule} from '@angular/common';
 import {FormControl, FormsModule, NG_VALUE_ACCESSOR, ReactiveFormsModule} from '@angular/forms';
 import {Subject} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
 import {isNullOrUndefined} from '@ironsource/fusion-ui/utils';
 import {IconData, IconModule} from '@ironsource/fusion-ui/components/icon/v1';
+import {GenericPipe} from '@ironsource/fusion-ui/pipes/generic';
+import {SearchTestIdModifiers} from '@ironsource/fusion-ui/entities';
+import {TestIdsService} from '@ironsource/fusion-ui/services/test-ids';
 
 @Component({
     selector: 'fusion-search',
     templateUrl: './search.component.html',
     styleUrls: ['./search.component.scss'],
     changeDetection: ChangeDetectionStrategy.OnPush,
     standalone: true,
-    imports: [CommonModule, FormsModule, ReactiveFormsModule, IconModule],
+    imports: [CommonModule, FormsModule, ReactiveFormsModule, IconModule, GenericPipe],
     providers: [
         {
             provide: NG_VALUE_ACCESSOR,
@@ -45,6 +48,9 @@ export class SearchComponent implements OnInit, OnDestroy {
         return this._showClearIcon;
     }
 
+    /** @internal */
+    @Input() testId: string;
+
     /** @internal */
     searchFormControl = new FormControl();
     /** @internal */
@@ -54,6 +60,13 @@ export class SearchComponent implements OnInit, OnDestroy {
     /** @internal */
     clearIcon: IconData = {iconName: 'cancel', iconVersion: 'v3'};
 
+    /** @internal */
+    searchTestIdModifiers: typeof SearchTestIdModifiers = SearchTestIdModifiers;
+    /** @internal */
+    testIdsService: TestIdsService = this.injector.get(TestIdsService);
+
+    constructor(private injector: Injector) {}
+
     ngOnInit() {
         this.searchFormControl.valueChanges.pipe(takeUntil(this.onDestroy$)).subscribe(value => {
             this.propagateTouched();

diff --git a/projects/fusion-ui/components/table/v3/components/table-basic/table-basic.component.html b/projects/fusion-ui/components/table/v3/components/table-basic/table-basic.component.html
@@ -10,6 +10,7 @@
         [isExpanded]="isExpanded(rowIndex)"
         [isInnerRow]="false"
         [class.is-row-in-request]="tableService.rowsMetadata[row['_rowId']]?.inRequest"
+        [testId]="testId"
         (rowRemoved)="tableService.removeRow({rows: rows, rowIndex: rowIndex, row: row, options: options})"
         (selectedChange)="tableService.onRowSelectChanged($event, row)"
         (expandRow)="onExpandRow($event)"

diff --git a/projects/fusion-ui/components/table/v3/components/table-basic/table-basic.component.ts b/projects/fusion-ui/components/table/v3/components/table-basic/table-basic.component.ts
@@ -5,6 +5,7 @@ import {
     Component,
     ElementRef,
     EventEmitter,
+    Injector,
     Input,
     OnDestroy,
     OnInit,
@@ -21,6 +22,8 @@ import {
 import {TableService} from '@ironsource/fusion-ui/components/table/common/services';
 import {fromEvent, Subject, from} from 'rxjs';
 import {filter, mergeMap, takeUntil} from 'rxjs/operators';
+import {TableTestIdModifiers} from '@ironsource/fusion-ui/entities';
+import {TestIdsService} from '@ironsource/fusion-ui/services/test-ids';
 
 @Component({
     // eslint-disable-next-line
@@ -44,6 +47,9 @@ export class TableBasicComponent implements OnInit, OnDestroy, AfterViewInit {
         this._halfTableClientWidth = value ? value / 2 : 0;
     }
 
+    /** @internal */
+    @Input() testId: string;
+
     @Output() rowSelected = new EventEmitter();
     @Output() expandRow = new EventEmitter<TableRowExpandEmitter>();
 
@@ -71,6 +77,11 @@ export class TableBasicComponent implements OnInit, OnDestroy, AfterViewInit {
     rowClass = this.getRowClass.bind(this);
     rowRowspanIndexes = this.getRowspanIndexes.bind(this);
 
+    /** @internal */
+    tableTestIdModifiers: typeof TableTestIdModifiers = TableTestIdModifiers;
+    /** @internal */
+    testIdsService: TestIdsService = this.injector.get(TestIdsService);
+
     private _halfTableClientWidth = 0;
     private tableOptions;
     private onDestroy$ = new Subject();
@@ -79,7 +90,8 @@ export class TableBasicComponent implements OnInit, OnDestroy, AfterViewInit {
         public tableService: TableService,
         private cdr: ChangeDetectorRef,
         private elementRef: ElementRef,
-        private renderer: Renderer2
+        private renderer: Renderer2,
+        private injector: Injector
     ) {}
 
     ngOnInit(): void {

diff --git a/projects/fusion-ui/components/table/v3/components/table-row/table-row.component.html b/projects/fusion-ui/components/table/v3/components/table-row/table-row.component.html
@@ -1,11 +1,12 @@
-<ng-container *ngFor="let expandCell of expandCellCount | async; let isLast = last">
+<ng-container *ngFor="let expandCell of expandCellCount | async; let isLast = last; let idx=index">
     <td *ngIf="cellShown | generic:'cell-expand'"
         class="expand-cell"
         [class.total-row]="isRowTotal"
         [class.expanded]="isExpanded"
         [class.inner-row]="isInnerRow"
         [class.sticky-left]="options?.rowsExpandableOptions?.sticky"
         [attr.rowspan]="attrRowspan | generic:'cell-expand'"
+        [attr.data-testid]="testIdsService.getTestAttribute.bind(this) | generic:testId:(tableTestIdModifiers.CELL+'-r'+rowIndex+'-c'+idx)"
     >
         <fusion-icon
             *ngIf="isLast && showExpandIcon()"
@@ -16,7 +17,7 @@
         </fusion-icon>
     </td>
 </ng-container>
-<ng-container *ngFor="let column of columns; trackBy: trackByFn; let columnIndex = index; let isLast = last;">
+<ng-container *ngFor="let column of columns; trackBy: trackByFn; let columnIndex = index; let isLast = last; let idx=index">
     <td *ngIf="cellShown | generic:column.key"
         fusionTableCell
         [fusionTooltip]="columnsData[columnIndex]?.tooltip"
@@ -41,6 +42,7 @@
         [style.width]="columnsData[columnIndex]?.width"
         [attr.colspan]="columnsData[columnIndex]?.colspan"
         [attr.rowspan]="attrRowspan | generic:column.key"
+        [attr.data-testid]="testIdsService.getTestAttribute.bind(this) | generic:testId:(tableTestIdModifiers.CELL+'-r'+rowIndex+'-c'+idx)"
         (remove)="rowRemoved.emit()"
         (selectedChange)="selectedChange.emit($event)"
         (dataChange)="onDataChange($event, column.key)"

diff --git a/projects/fusion-ui/components/table/v3/components/table-row/table-row.component.ts b/projects/fusion-ui/components/table/v3/components/table-row/table-row.component.ts
@@ -4,6 +4,7 @@ import {
     Component,
     EventEmitter,
     HostBinding,
+    Injector,
     Input,
     OnChanges,
     OnInit,
@@ -17,6 +18,8 @@ import {Observable, of} from 'rxjs';
 import {ColumnData} from './column-data';
 import {TableRow} from '@ironsource/fusion-ui/components/table/common/entities';
 import {IconData} from '@ironsource/fusion-ui/components/icon/v1';
+import {TableTestIdModifiers} from '@ironsource/fusion-ui/entities';
+import {TestIdsService} from '@ironsource/fusion-ui/services/test-ids';
 
 @Component({
     // eslint-disable-next-line
@@ -36,6 +39,10 @@ export class TableRowComponent implements OnInit, OnChanges {
     @Input() isExpanded: boolean;
     @Input() isInnerRow: boolean;
     @Input() hasAfterSticky: boolean;
+
+    /** @internal */
+    @Input() testId: string;
+
     @Output() rowRemoved = new EventEmitter();
     @Output() selectedChange = new EventEmitter();
     @Output() expandRow = new EventEmitter<TableRowExpandEmitter>();
@@ -69,6 +76,11 @@ export class TableRowComponent implements OnInit, OnChanges {
     cellShown = this.showCell.bind(this);
     attrRowspan = this.getAttrRowspan.bind(this);
 
+    /** @internal */
+    tableTestIdModifiers: typeof TableTestIdModifiers = TableTestIdModifiers;
+    /** @internal */
+    testIdsService: TestIdsService = this.injector.get(TestIdsService);
+
     get expandCellCount(): Observable<number[]> {
         if (!!this.options && !!this.options.rowsExpandableOptions && !!this.tableService.expandLevels) {
             const expandLevelsByIndex = this.tableService.getExpandLevelByRowIndex(this.rowIndex);
@@ -100,7 +112,7 @@ export class TableRowComponent implements OnInit, OnChanges {
         };
     }
 
-    constructor(public tableService: TableService, private cdRef: ChangeDetectorRef) {}
+    constructor(public tableService: TableService, private cdRef: ChangeDetectorRef, private injector: Injector) {}
 
     ngOnInit(): void {
         this.dataRowIndex = this.rowIndex;

diff --git a/projects/fusion-ui/components/table/v3/stories/table.component.stories.ts b/projects/fusion-ui/components/table/v3/stories/table.component.stories.ts
@@ -65,7 +65,8 @@ export default {
     args: {
         options: TABLE_DEFAULT_OPTIONS,
         columns: TABLE_DEFAULT_COLUMNS_CONFIG,
-        rows: ROWS_DEFAULT_DATA
+        rows: ROWS_DEFAULT_DATA,
+        testId: 'test-id'
     }
 } as Meta<TableComponent>;
 
@@ -76,6 +77,7 @@ const TableTemplate: StoryFn<TableComponent> = (args: TableComponent) => ({
     [columns]="columns"
     [rows]="rows"
     [loading]="loading"
+    [testId]="testId"
 ></fusion-table>`
 });
 
@@ -85,6 +87,7 @@ const TableWithHostTemplate: StoryFn<TableComponent> = (args: TableComponent) =>
     [options]="options"
     [columns]="columns"
     [rows]="rows"
+    [testId]="testId"
 ></fusion-table-story-holder>`
 });