deletes multisig identity on account import #5692
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the identity will always be stored on the multisig identity we don't need to maintain the record of the identity separately in the multisigIdenitities store keeping identities in this store can be confusing for future use when generating new accounts deletes any existing identity that matches the identity on the imported account instead of adding an identity to the store if it is missing removes DuplicateIdentityNameError, which is no longer thrown removes tests that checked duplicate identity name logic on import
hughy
force-pushed
the
feat/hughy/delete-multisig-identity
branch
from
48d0b68 to
38e89ad
Compare
hughy
added
the
breaking-change-sdk
|
We still rely on reading from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
since the identity will always be stored on the multisig identity we don't need to maintain the record of the identity separately in the multisigIdenitities store
keeping identities in this store can be confusing for future use when generating new accounts
deletes any existing identity that matches the identity on the imported account instead of adding an identity to the store if it is missing
removes DuplicateIdentityNameError, which is no longer thrown
removes tests that checked duplicate identity name logic on import
Closes IFL-3117
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.