Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names an account with last 4 of address if no name exists #301

Merged
merged 9 commits into from
Jan 22, 2025
Merged

Names an account with last 4 of address if no name exists #301

merged 9 commits into from
Jan 22, 2025

Conversation

cgjohn
Copy link
Contributor

@cgjohn cgjohn commented Jan 17, 2025

dguenther
dguenther approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and seems to work great! I added a couple suggestions for improvements. The only one I feel strongly about is the switch to electron-log. The other ones would be nice to address, but not blocking if you think they'll take a bit or disagree

main/api/accounts/handleGetAccounts.ts Outdated Show resolved Hide resolved
main/api/accounts/handleGetAccounts.ts Outdated Show resolved Hide resolved
main/api/accounts/handleGetAccounts.ts Outdated Show resolved Hide resolved
main/api/accounts/handleGetAccounts.ts Outdated Show resolved Hide resolved
dguenther
dguenther reviewed Jan 21, 2025
View reviewed changes
main/api/manager.ts Outdated Show resolved Hide resolved
main/api/manager.ts Outdated Show resolved Hide resolved
main/api/manager.ts Outdated Show resolved Hide resolved
main/api/manager.ts Outdated Show resolved Hide resolved
main/api/manager.ts Outdated Show resolved Hide resolved
cgjohn
cgjohn commented Jan 22, 2025
View reviewed changes
main/api/manager.ts Outdated Show resolved Hide resolved
@dguenther dguenther merged commit 902f9fc into main Jan 22, 2025
1 check passed
@dguenther dguenther deleted the node-app-fix-no-named-accounts branch January 22, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgca dgca dgca left review comments

@dguenther dguenther dguenther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgjohn @dguenther @dgca