Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2211,2212,2213] Testing fixes (4-3-stable) #2214

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

FifthPotato
Copy link
Contributor

Replace all instances of assertEquals with assertEqual
Do not install unittest-xml-reporting==1.14.0
Version-sniff to avoid upgrading pip on Ubuntu 24 and later

Needed for testing. Tests pass.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's wait for one more approval before pounding.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for the time being. Let's # it

Replace all instances of assertEquals with assertEqual
Do not install unittest-xml-reporting==1.14.0
Version-sniff to avoid upgrading pip on Ubuntu 24 and later
@FifthPotato
Copy link
Contributor Author

Octothorpe'd.

@alanking alanking merged commit adda59c into irods:4-3-stable Aug 22, 2024
1 of 2 checks passed
@alanking
Copy link
Contributor

@FifthPotato - Please check boxes in linked issues and cherry-pick to main. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants