Fixes for test hook (4-2-stable) #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
reviewed
Apr 5, 2022
Add --test, --skip-setup, and --teardown-minio options to test hook. --skip-setup skips downloading and starting the MinIO service which means that the user running the test assumes that MinIO is already running in the configuration expected by the tests. --teardown-minio will terminate the MinIO processes after running the tests. --skip-setup and --teardown-minio are incompatible parameters because the process object returned from subprocess.Popen must be available to execute the termination logic, which is only the case when setup is performed on the same test hook invocation. Also replaced usage of deprecated features of MinIO: - Replaced usage of MINIO_ACCESS_KEY and MINIO_SECRET_KEY with MINIO_ROOT_USER and MINIO_ROOT_PASSWORD - Started using --console-address to explicitly specify the API port for the MinIO server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapted from changes in #2027