ipykernel 7 support #898
Merged
ipykernel 7 support #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle async methods - zmq.asyncio.Sockets, not ZMQStreams - need to enable ControlThread now that flush is not an option
while ipykernel 7 has unmerged fixes
get running loop instead
don't wait forever if there's a problem
- refactor redirect output, redirect it later and stop redirecting during shutdown so errors in ipengine/kernel are more likely to be seen in the terminal - fix SIGTERM handler so it actually fires in the event loop
|
most tests passing, need to fix become_dask and some magics tests, then make sure the fixes didn't break with ipykernel 6 |
remove backports of ipykernel abort methods no longer needed with a newer minimum ipykernel remove notebook 4.1 backward-compat
call_soon doesn't launch coroutines
|
almost got it. #899 fixed slurm, but this has broken it again. I'm guessing related to the signal handling/shutdown, since slurm tests are running with stable ipykernel |
works fine locally, I'm tired
I can't right now
|
@Carreau this is all passing with ipykernel 7, once the above fixes are merged into ipykernel itself. |
asyncio.run doesn't exit when you stop the loop (?!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs some fixes in ipykernel as well before 7 is released
requires upstream PRs:
closes #895