Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : enable task subclassing #17

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

cardinam
Copy link
Contributor

No description provided.

@cardinam cardinam marked this pull request as draft February 13, 2024 10:44
@cardinam cardinam marked this pull request as ready for review February 13, 2024 10:46
@cardinam cardinam requested a review from yboussard February 13, 2024 10:46
@cardinam cardinam force-pushed the feature/enable-task-subclassing branch from 691bece to 21f4fb8 Compare February 13, 2024 12:11
@cardinam cardinam force-pushed the feature/enable-task-subclassing branch 10 times, most recently from d7dd719 to 93a5130 Compare February 13, 2024 13:46
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eb88cc9) 98.19% compared to head (93a5130) 97.49%.

❗ Current head 93a5130 differs from pull request most recent head fd4a3e8. Consider uploading reports for the commit fd4a3e8 to get more accurate results

Files Patch % Lines
taskq/task.py 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   98.19%   97.49%   -0.70%     
==========================================
  Files          10       10              
  Lines         387      399      +12     
  Branches       43       45       +2     
==========================================
+ Hits          380      389       +9     
- Misses          7        9       +2     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardinam cardinam force-pushed the feature/enable-task-subclassing branch from 93a5130 to 6ae93b2 Compare February 13, 2024 16:07
@cardinam cardinam force-pushed the feature/enable-task-subclassing branch from 6ae93b2 to fd4a3e8 Compare February 13, 2024 16:09
@cardinam cardinam merged commit 8b0ad97 into master Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant