fix(gateway): clarify cache-control of generated html on /ipfs #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
changed the title
lidel
force-pushed
the
fix/cache-control-of-generated-html
branch
from
a9ab757
to
d3cdb71
Compare
lidel
changed the title
4 tasks
lidel
commented
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies and recommends
Cache-Controlvalue to be returned on generated HTML responses such as UnixFS Directory listings, raised by @acejam in ipfs/boxo#639 & ipfs/gateway-conformance#219.No IPIP since this is a gap is specs surface, not a change to existing spec.