Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom dnslink resolvers #224

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

aschmahmann
Copy link
Contributor

Adds the ability to configure custom DNSLink resolvers

@aschmahmann aschmahmann force-pushed the feat/configurable-dnslink-resolvers branch from 6ca2e4d to 4130c06 Compare December 23, 2024 16:29
including explicit defaults

It is possible to override OS resolver by passing root: `. : catch-URL`.

Default: `eth. : https://resolver.cloudflare-eth.com/dns-query, crypto. : https://resolver.cloudflare-eth.com/dns-query`
Copy link
Member

@lidel lidel Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ documented that we are keeping the same value as implicit default from boxo for now – just documenting what these are and making them explicit in rainbow's default config.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be enough to release as .1 and fix problem at hand.

@lidel lidel merged commit 21872f4 into main Dec 23, 2024
10 checks passed
@lidel lidel deleted the feat/configurable-dnslink-resolvers branch December 23, 2024 17:44
@lidel lidel mentioned this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants