Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayCLI for stat bw CLI command #8358

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbouwman
Copy link
Contributor

Replace PostRun with DisplayCLI

Initial test PR to shake out issues related to ipfs/go-ipfs-cmds#215 according to recommendation in ipfs/go-ipfs-cmds#115

  • Distinguishes polled/non polled output cases in text-specific DisplayCLI output mode.
  • Certainly breaks &encoding=text API output - to be explored
  • Closes ipfs stats bw doesn't support --enc json #5594 by exposing json and xml output via global --encoding flag
  • go.mod points to a specific commit in a fork of go-ipfs-cmds, which will probably fail some sharness tests

Distinguish polled/non polled output cases in text-specific DisplayCLI output mode.

Exposes ability to request json and xml output, according to global `--encoding` flag.
@BigLep
Copy link
Contributor

BigLep commented Mar 10, 2022

@jbouwman : is this PR still relevant? If so, can you rebase? We're sweeping through old PRs and want to get a current inventory.

Also, does this fully address #5594 or is there more to cover?

@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

ipfs stats bw doesn't support --enc json
2 participants