Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: webui v2.11.1 #7669

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

rafaelramalho19
Copy link
Contributor

@rafaelramalho19 rafaelramalho19 commented Sep 10, 2020

@aschmahmann
Copy link
Contributor

@rafaelramalho19 could you rebase on master, it looks like you have a conflict.

@rafaelramalho19
Copy link
Contributor Author

@rafaelramalho19 could you rebase on master, it looks like you have a conflict.

Thanks, we'll have to do a new webui release soon, so please don't merge this yet

@lidel
Copy link
Member

lidel commented Sep 14, 2020

Update: turned out that fix in ipfs/ipfs-webui#1628 was specific to ipfs-desktop and does not impact use in regular browsers, so there is no need to block go-ipfs on this.

@aschmahmann if you want, feel free to squash & merge as-is (v2.11.0), no need to wait for v2.11.1

@aschmahmann
Copy link
Contributor

@lidel @rafaelramalho19 Have we done some tests with this version of go-ipfs + webui just to make sure everything looks right before merging?

Was hoping to do the full release tomorrow or Wednesday (pending an issue I'm investigating) so if the new WebUI is up by then or you need a bit more time lmk.

@lidel
Copy link
Member

lidel commented Sep 14, 2020

Cool, I believe we should have new webui by tomorrow :)
If we don't update this PR by then, feel free to merge as-is.

As for tests, so far all good:

  • End-to-end regression tests are green with 0.7.0-rc2
    (we run them CI against the custom binary, config is in .circleci/config.yml#L257-L287)
  • I've been using webui v2.11 with 0.7.0-rc2 for about a week without any regressions
    • On top of UI fixes/improvements, the key benefit of this release is that one can import big files without buffering the entire thing in browser's memory. Import of a 2GB video takes a moment, but is no longer crashing my browser.
  • I did some manual tests while working on CORS, scenarios right after ipfs init (vanilla state) and custom setup with API running on custom port also work as expected

@rafaelramalho19
Copy link
Contributor Author

I've bumped webui version to the latest now

@lidel lidel changed the title Chore/bump webui chore: webui v2.11.1 Sep 15, 2020
@aschmahmann aschmahmann merged commit 1b4f5e7 into ipfs:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants