Apply suggestions from code review

Co-authored-by: Daniel Norman <[email protected]>
ipfs · Apr 1, 2024 · 0f3837f · 0f3837f
1 parent ffafe6d
commit 0f3837f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -16,7 +16,7 @@ import type { CID } from 'multiformats/cid'
 
 const log = logger('ipns')
 const ID_MULTIHASH_CODE = identity.code
-const DEFAULT_TTL_NS = BigInt(3.6e+12) // 1 Hour or 3600 Seconds
+const DEFAULT_TTL_NS = 60 * 60 * 1e+9 // 1 Hour or 3600 Seconds
 
 export const namespace = '/ipns/'
 export const namespaceLength = namespace.length
@@ -129,7 +129,7 @@ export interface IDKeys {
 }
 
 export interface CreateOptions {
-  ttlNs?: bigint
+  ttlNs?: number | bigint
   v1Compatible?: boolean
 }
 

diff --git a/test/index.spec.ts b/test/index.spec.ts
@@ -32,7 +32,7 @@ describe('ipns', function () {
 
   it('should create an ipns record (V1+V2) correctly', async () => {
     const sequence = 0
-    const ttl = BigInt(3.6e+12)
+    const ttl = 3.6e+12
     const validity = 1000000
 
     const record = await ipns.create(peerId, contentPath, sequence, validity)
@@ -68,7 +68,7 @@ describe('ipns', function () {
 
   it('should create an ipns record (V2) correctly', async () => {
     const sequence = 0
-    const ttl = BigInt(3.6e+12)
+    const ttl = 3.6e+12
     const validity = 1000000
 
     const record = await ipns.create(peerId, contentPath, sequence, validity, { v1Compatible: false })
@@ -134,7 +134,7 @@ describe('ipns', function () {
 
   it('should be able to create a record (V1+V2) with a fixed ttl', async () => {
     const sequence = 0
-    const ttl = BigInt(0.6e+12)
+    const ttl = 0.6e+12
     const validity = 1000000
 
     const record = await ipns.create(peerId, contentPath, sequence, validity, {
@@ -162,7 +162,7 @@ describe('ipns', function () {
 
     await ipnsValidator(peerIdToRoutingKey(peerId), marshalledRecord)
 
-    const pb = IpnsEntry.decode(ipns.marshal(record))
+    const pb = IpnsEntry.decode(marshalledRecord)
     expect(pb).to.not.have.property('ttl')
 
     const data = parseCborData(pb.data ?? new Uint8Array(0))