Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update app.Version to match with 0.10.0 release #147

Closed
wants to merge 1 commit into from
Closed

fix: update app.Version to match with 0.10.0 release #147

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 commented Oct 22, 2023

@welcome
Copy link

welcome bot commented Oct 22, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann
Copy link
Contributor

aschmahmann commented Oct 23, 2023

@chenrui333 can you make this v0.10.1, we already have a v0.10.0 tag so this won't quite match up. Thanks for the report and PR.

@chenrui333
Copy link
Author

@chenrui333 can you make this v0.10.1, we already have a v0.10.0 tag so this won't quite match up. Thanks for the report and PR.

totally!

@chenrui333
Copy link
Author

@aschmahmann let me know if it works better now.

Copy link

Suggested version: v0.10.1

Comparing to: v0.10.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.10.1

gocompat says:

Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

Pre-creating GitHub Releases on release PRs initiated from forks is not supported.
If you wish to prepare release notes yourself, you should create a draft GitHub Release for tag v0.10.1 manually.
The draft GitHub Release is going to be published when this PR is merged.
If you choose not to create a draft GitHub Release, a published GitHub Released is going to be created when this PR is merged.

@gammazero
Copy link
Contributor

As per #113 version.json should be the source of truth. @chenrui333 Thank you for this PR, but I think #149 is preferable as it compiles the version in, using he value from version.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version report issue with 0.10.0 release
3 participants