Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go-ipfs 0.6 #1526

Merged
merged 4 commits into from
Jul 6, 2020
Merged

feat: go-ipfs 0.6 #1526

merged 4 commits into from
Jul 6, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented May 27, 2020

This PR bumps go-ipfs to 0.6

Before merging:

  • test locally with RC1
  • wait for final release
  • remove go-ipfs block from package.json and update go-ipfs-dep to 0.6.0

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
Copy link
Member Author

lidel commented May 27, 2020

@rafaelramalho19 in spare moment, can you test this branch on macOS and Windows
(npm ci && run-s clean:webui build:webui && DEBUG='desktop' npm start)?

Most of the stuff is covered by E2E but we dont test directory imports,
so just open WebUI, try to add a directory (via button, then via drag & drop).

@rafaelramalho19
Copy link
Contributor

Everything is working fine in both macos and windows 😄

@lidel
Copy link
Member Author

lidel commented Jun 18, 2020

Bumped to RC7 (ipfs/kubo#7347 (comment)), looks good.
Waiting for final release.

@pomazanbohdan
Copy link

pomazanbohdan commented Jun 22, 2020

  • wait for final release

@lidel
Copy link
Member Author

lidel commented Jun 22, 2020

Waiting for: https://www.npmjs.com/package/go-ipfs-dep to be fixed by ipfs-inactive/npm-go-ipfs-dep#43

Update: done!

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel lidel requested a review from rafaelramalho19 June 22, 2020 21:52
@lidel lidel marked this pull request as ready for review June 22, 2020 21:52
@lidel
Copy link
Member Author

lidel commented Jun 23, 2020

@rafaelramalho19 FYSA there will be patch release 0.6.1 next week,
so its ok to wait and bump this PR then, when you are back next week.
(A lot of stuff happening this week anyway 🙀 )

@lidel
Copy link
Member Author

lidel commented Jul 6, 2020

@rafaelramalho19 turns out the patch did not land in expected time.

I asked and it is not really relevant to desktop users, so please merge this PR as-is, and also new webui from #1455 Then check if master works fine on mac/windows and if all good ship a new 0.11.5(?)

@rafaelramalho19 rafaelramalho19 merged commit a4ecb61 into master Jul 6, 2020
@rafaelramalho19 rafaelramalho19 deleted the feat/go-ipfs-0.6.0 branch July 6, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants