Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Native feel of Browser Action popups #339

Closed
wants to merge 1 commit into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 16, 2017

The goal of this PR is to make the little triangle at the top of the popup feel "native" (where possible).
I am not sure if we can make it work across all browsers, so this is kind of an "exploratory PR".

Rationale:

  • Better UX with dark themes
  • Native look-and-feel increases trust (tm)
  • Future features (eg. Expose IPFS API as window.ipfs #330) will require us to display permission dialogs. Lost likely via browser action popup. We want it to look real, not like a phishing attack. (well, we could just use white background, but still..)

Remaining work

  • Firefox
  • Chrome (if possible)
  • Brave (if possible)

@lidel lidel added this to the 2018-Q1 milestone Dec 16, 2017
@lidel lidel requested review from olizilla and alanshaw December 16, 2017 14:15
@lidel
Copy link
Member Author

lidel commented Dec 16, 2017

Firefox

Before

2017-12-16-144623_1718x1419_scrot

After

2017-12-16-142252_1146x711_scrot

@olizilla
Copy link
Member

I think we only added the border to try and make it look consistent across browsers, and to partially re-create the firefox specific styling that used to be there. I'm in favour of tailoring the styles so blends in nicely to each browser, if possible. They each, as always, seem to have their own unique quirks.

@alanshaw
Copy link
Member

I did it like this in Firefox originally (since Firefox is my main browser), but Chrome/Brave have a 1px white border and doesn't allow you to style the arrow like that. It was simplest to keep them all consistent when I originally did the work but if this looks ok in Chrome/Brave and doesn't complicate things too much then I'm ok with it...I mean I'd prefer it if all the browsers looked like what you're proposing!

@alanshaw
Copy link
Member

Note that in macOS Firefox the borders have radius. I think this is one of the things that made it complicated because you'd have to remove it from Chrome, and FF Linux...

screen shot 2017-12-18 at 10 17 09

@lidel
Copy link
Member Author

lidel commented Dec 18, 2017

Thanks for the feedback! I noticed the issue under Chrome too -- no matter what I do the white arrow is not styled. Unfortunate. We should avoid browser-specific CSS, so let's park this PR for now.

I feel we will either:

  • abandon the idea and leave it as-is
  • move icon with dark background to the bottom: that way all browsers have seamless arrow in white color

@alanshaw
Copy link
Member

alanshaw commented Feb 1, 2018

IMHO I think we should leave it as is for now

@lidel
Copy link
Member Author

lidel commented Feb 1, 2018

Yeah, I think we can revisit this when style guide lands, but that will be a different PR. Closing this one.

@lidel lidel closed this Feb 1, 2018
@lidel lidel deleted the native-browser-action-popup branch February 1, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants