Skip to content

Commit

Permalink
fix: do not depend on external domains in dnslink tests (#547)
Browse files Browse the repository at this point in the history
Dependency on third-party domains means  that over time
CI will break, like it did in
https://github.com/ipfs/kubo/actions/runs/9214249430/job/25364989609?pr=10429#step:9:63

Error: queryCname ENODATA singularity.storage

There three domains left here are enough to cover all cases.

Ideally, CI would not depend on internet DNS, and have static fixtures
and custom localhost DNS server, but this should be good enough to stop
breaking Kubo CI etc
  • Loading branch information
lidel authored May 27, 2024
1 parent 011fa92 commit 21ef20c
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions packages/interop/src/ipns-dnslink.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,9 @@ import type { IPNS } from '@helia/ipns'
import type { HeliaLibp2p } from 'helia'

const TEST_DOMAINS: string[] = [
'ipfs.io',
'ipfs.tech',
'docs.ipfs.tech',
'en.wikipedia-on-ipfs.org',
'blog.libp2p.io',
'consensuslab.world',
'n0.computer',
'protocol.ai',
'research.protocol.ai',
'probelab.io',
'singularity.storage',
'saturn.tech'
'en.wikipedia-on-ipfs.org'
]

describe('@helia/ipns - dnslink', () => {
Expand Down

0 comments on commit 21ef20c

Please sign in to comment.