Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docs and depcheck error #159

Closed
wants to merge 1 commit into from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Dec 4, 2024

This is one way to resolve the issue mentioned by @2color in #156 (comment)

it removes the need to add a //ts-expect-error in the example code generated on the README.md

@SgtPooki SgtPooki requested a review from a team as a code owner December 4, 2024 15:33
@achingbrain
Copy link
Member

The problem with this approach, if we get into a habit of it, is that we will now receive dependabot updates for this extra dep, increasing maintenance friction, and potentially security notices if something nasty is discovered in the unused dep which causes noise.

@SgtPooki
Copy link
Member Author

SgtPooki commented Dec 4, 2024

This is not needed with the addition of ipfs/aegir#1701

@SgtPooki SgtPooki closed this Dec 4, 2024
@SgtPooki
Copy link
Member Author

SgtPooki commented Dec 4, 2024

The problem with this approach, if we get into a habit of it, is that we will now receive dependabot updates for this extra dep, increasing maintenance friction, and potentially security notices if something nasty is discovered in the unused dep which causes noise.

100%.. the PR you put up is the right long-term fix

@2color
Copy link
Member

2color commented Dec 4, 2024

Thanks for jumping in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants