Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore Error: prefix #81

Merged
merged 1 commit into from
Mar 17, 2018
Merged

restore Error: prefix #81

merged 1 commit into from
Mar 17, 2018

Conversation

Stebalien
Copy link
Member

this is a breaking change and many of our tests expect this

this is a breaking change and many of our tests expect this
@ghost ghost assigned Stebalien Mar 17, 2018
@ghost ghost added the status/in-progress In progress label Mar 17, 2018
@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   43.02%   43.02%           
=======================================
  Files          23       23           
  Lines        1922     1922           
=======================================
  Hits          827      827           
  Misses        960      960           
  Partials      135      135
Impacted Files Coverage Δ
cli/run.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3940b10...b32936a. Read the comment docs.

@dignifiedquire
Copy link
Member

any chance we can make that an option? otherwise I will need to maintain a copy with that change :/

@Stebalien
Copy link
Member Author

any chance we can make that an option? otherwise I will need to maintain a copy with that change

I'd rather not; I can't see a clean way of doing that without adding yet another argument to that function. Why do you need this change?

Ideally, we wouldn't print any errors, we'd just return them. However, that makes printing help awkward.

@Stebalien
Copy link
Member Author

I'm going to merge this for now as this was a breaking change, we need to cut a go-ipfs release, and I didn't really consider the impact when I merged #68. We can discuss solutions to this in #82.

@Stebalien Stebalien merged commit 6a0bd97 into master Mar 17, 2018
@ghost ghost removed the status/in-progress In progress label Mar 17, 2018
@Stebalien Stebalien deleted the fix/error-printing branch March 17, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants