fix(NewClient): support https:// URLs (#277)

* fix(NewClient): support https:// URLs We don't hardcode any specific ports, but assume `http://` (backward-compatible behavior) unless `https://` is passed (then we keep it as-is). * chore: v0.14.1 this is backward-compatible fix, ok to just bump patch
ipfs · Jan 10, 2025 · a32ea33 · a32ea33
1 parent 2432d3e
commit a32ea33
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/http/client.go b/http/client.go
@@ -85,7 +85,8 @@ func ClientWithRawAbsPath(rawAbsPath bool) ClientOpt {
 
 // NewClient constructs a new HTTP-backed command executor.
 func NewClient(address string, opts ...ClientOpt) cmds.Executor {
-	if !strings.HasPrefix(address, "http://") {
+	// default to HTTP to keep backward-compatible behavior, but keep https:// if passed
+	if !strings.HasPrefix(address, "http:") && !strings.HasPrefix(address, "https:") {
 		address = "http://" + address
 	}
 

diff --git a/version.json b/version.json
@@ -1,3 +1,3 @@
 {
-  "version": "v0.14.0"
+  "version": "v0.14.1"
 }