Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
amend the CidFromReader slice extension math
The append+make slice extension idiom works, but note that append uses the slice's length as its base. We need to append the number of bytes required for length to reach cidLength, not the capacity. The added test case panicked before this change, and works now: --- FAIL: TestReadCidsFromBuffer (0.00s) panic: runtime error: slice bounds out of range [:73] with capacity 64 [recovered] panic: runtime error: slice bounds out of range [:73] with capacity 64 goroutine 37 [running]: testing.tRunner.func1.2({0x570d60, 0xc000016438}) testing/testing.go:1203 +0x24e testing.tRunner.func1() testing/testing.go:1206 +0x218 panic({0x570d60, 0xc000016438}) runtime/panic.go:1038 +0x215 github.com/ipfs/go-cid.CidFromReader({0x5b0e20, 0xc000010900}) github.com/ipfs/go-cid/cid.go:803 +0x75f github.com/ipfs/go-cid.TestReadCidsFromBuffer(0xc00014ba00) github.com/ipfs/go-cid/cid_test.go:710 +0x625 testing.tRunner(0xc00014ba00, 0x58af38) testing/testing.go:1253 +0x102 created by testing.(*T).Run testing/testing.go:1300 +0x35a exit status 2 FAIL github.com/ipfs/go-cid 0.004s
- Loading branch information