Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp. grant admin to lidel to facilitate repo migration #202

Merged
merged 2 commits into from
May 9, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented May 8, 2024

Summary

Why do you need this?

I want to finish ipfs/service-worker-gateway#80 but Cloudflare Pages introduced in ipfs/service-worker-gateway#244 do not support switching repos, so it is likely integration will break after a move.

If that happens, I need to recreate the project and grant permissions, and afaik only admin can do it, granting me temp. admin is the simplest way to finish migration.

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@lidel lidel requested review from a team as code owners May 8, 2024 21:19
@lidel lidel requested a review from galargh May 8, 2024 21:19
Copy link
Contributor

github-actions bot commented May 8, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User lidel:
  - will have the role in the organization change from member to admin

@@ -18,6 +18,9 @@ members:
# 1. co-founder of [IPDX](https://ipdx.co), and IPDX is contracted to look after GitHub for this organization.
# 2. Multiple years of experience managing GitHub organizations of open source projects, including this org.
- galargh
# Why @lidel
# Need admin to finish https://github.com/ipfs-shipyard/helia-service-worker-gateway/issues/80
- lidel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove yourself from members for this to work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct! It'd be nice if it happened automatically. I made this change now, will be ready for merge soon.

Copy link
Contributor

github-actions bot commented May 9, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_membership.this["lidel"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipfs:lidel"
      ~ role     = "member" -> "admin"
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@galargh galargh merged commit a020c61 into master May 9, 2024
6 checks passed
@lidel lidel deleted the lidel-patch-1 branch May 9, 2024 12:53
lidel added a commit that referenced this pull request May 9, 2024
Reverting #202 as I finished ipfs/service-worker-gateway#80 and no longer need elevated permissions.
@lidel lidel mentioned this pull request May 9, 2024
4 tasks
lidel added a commit that referenced this pull request May 9, 2024
Reverting #202 as I finished ipfs/service-worker-gateway#80 and no longer need elevated permissions.
Stebalien pushed a commit that referenced this pull request May 12, 2024
Reverting #202 as I finished ipfs/service-worker-gateway#80 and no longer need elevated permissions.

Co-authored-by: ipfs-mgmt-read-write[bot] <104492829+ipfs-mgmt-read-write[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants