Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary vesahc admin access #200

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

Stebalien
Copy link
Member

Summary

See the comment, it's after March 31st.

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@Stebalien Stebalien requested review from a team as code owners April 14, 2024 16:04
@Stebalien Stebalien requested a review from laurentsenta April 14, 2024 16:04
Copy link
Contributor

github-actions bot commented Apr 14, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User vesahc:
  - will have the role in the organization change from admin to member

@Stebalien
Copy link
Member Author

@galargh any idea what the test failure is?

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_membership.this["vesahc"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipfs:vesahc"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@galargh
Copy link
Contributor

galargh commented Apr 15, 2024

@galargh any idea what the test failure is?

It's because we don't allow removing members from the organization or deleting repositories via GitHub as Code. This is because these two actions are harder to revert.

I moved vesahc to the regular members group of the organization. Would that be OK?

Other than than that, the PR looks good 👍

@Stebalien
Copy link
Member Author

It's because we don't allow removing members from the organization or deleting repositories via GitHub as Code. This is because these two actions are harder to revert.

Ah, I see. Yeah, that makes sense.

@Stebalien Stebalien merged commit 4de6c6b into master Apr 15, 2024
6 checks passed
@Stebalien Stebalien deleted the steb/remove-temp-vesahc branch April 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants