Support plugin builds #856
Conversation
Placing a "plugin" file in the `dists/<repo>` folder will trigger a -buildmode=plugin build using CGO.
There was a problem hiding this comment.
I assume you've been testing with #857, has that been working alright?
Don't see anything outstanding outside of the two comments below so LGTM, although I haven't done any local testing so if anyone else wants to give some 👀 (especially ones that barely know bash 😅) that could be useful.
| @@ -211,6 +225,7 @@ function printInitialDistfile() { | |||
| "owner": "$(< repo-owner)", | |||
| "description": "$(< description)", | |||
| "date": "$(date -u '+%B %d, %Y')", | |||
| "plugin": "$plugin", | |||
There was a problem hiding this comment.
where is this set? (sorry if this is just obvious, my shell is pretty meh)
| local plugin="false" | ||
| if [ -e plugin ]; then | ||
| plugin="true" | ||
| fi |
There was a problem hiding this comment.
Are you manually adding a plugin file to indicate something is a plugin? If so could you document it, and if not too painful add it to dist.sh new-go-dist? If it's a pain then just documenting should be fine.
It "works"... but I don't find it very clean, the approach is a bit arbitrary. Moreover the CI is not prepared to build on anything non linux/amd64, because gcc cross-compiling tools are not installed, and I look to at least have darwin and apparently it is not as easy as installing a gcc package. So I'm not sure it is worth merging. I thought building the plugin in the exact conditions that Kubo is built would ensure compatibility, but also apparently the plugin just works fine now by building directly by hand (I have no idea if it has to do with Boxo, with re-organizing code, with tagged releases of things or what exactly...). |
Placing a "plugin" file in the
dists/<repo>folder will trigger a -buildmode=plugin build using CGO.