-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): add http retries and bigger timeouts #533
Conversation
This change produced no new differences in built artifacts. |
What does this mean it'll just hang forever unless you tell it explicitly how long to timeout after? It's fine to increase the timeout here, but it'd be nice if we could error here and kill the build instead of rebuilding any binaries where we failed to do the This behavior of rebuilding on failure is also a little bit dangerous in the sense that it seems like we could end up pushing binary changes to dist.ipfs.io for old binaries accidentally. |
8cf1381
to
d4972e8
Compare
I meant implicit timeout in That being said, it does not seem to be low enough (20m) to produce issues we experience (timeout <1m). Pushed some explicit retries and timeouts and restarted the job. If it fails again, let's wait for github to calm down until tomorrow. |
This change produced no new differences in built artifacts. |
This change produced no new differences in built artifacts. |
This change produced no new differences in built artifacts. |
1 similar comment
This change produced no new differences in built artifacts. |
This change produced no new differences in built artifacts. |
Aims to close #532 by bumping timeout from 1m:
TODO
update to latest http client, which no longer have client-side timeoutsnvm, 🕳️ 🐇, not touching this before xmasipfs-http-client
operations duringpublish
step