Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add http retries and bigger timeouts #533

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 15, 2021

Aims to close #532 by bumping timeout from 1m:

TODO

  • add retry to curl that downloads go-ipfs binary
  • update to latest http client, which no longer have client-side timeouts nvm, 🕳️ 🐇, not touching this before xmas :trollface:
  • instead, set global timeout of 45m for all ipfs-http-client operations during publish step

@lidel lidel marked this pull request as draft December 15, 2021 19:22
@lidel lidel changed the title fix(ci) bump ipfs.cat timeout to 5m fix(ci): remove ipfs.cat timeout of 1m Dec 15, 2021
@lidel lidel temporarily deployed to Deploy December 15, 2021 19:25 Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

@aschmahmann
Copy link
Contributor

aschmahmann commented Dec 15, 2021

update to latest http client, which no longer have client-side timeouts

What does this mean it'll just hang forever unless you tell it explicitly how long to timeout after? It's fine to increase the timeout here, but it'd be nice if we could error here and kill the build instead of rebuilding any binaries where we failed to do the ipfs cat.

This behavior of rebuilding on failure is also a little bit dangerous in the sense that it seems like we could end up pushing binary changes to dist.ipfs.io for old binaries accidentally.

@lidel
Copy link
Member Author

lidel commented Dec 15, 2021

I meant implicit timeout in [email protected] (code here).
iiuc it will timeout after 20 minutes even if go-ipfs default is to wait for data forever.

That being said, it does not seem to be low enough (20m) to produce issues we experience (timeout <1m).
It starts to look like an issue with github infra itself: docker just failed to start witht he same context deadline exceeded error 🙃

Pushed some explicit retries and timeouts and restarted the job. If it fails again, let's wait for github to calm down until tomorrow.

@lidel lidel changed the title fix(ci): remove ipfs.cat timeout of 1m fix(ci): add http retries and bigger timeouts Dec 15, 2021
@lidel lidel temporarily deployed to Deploy December 15, 2021 20:44 Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

@lidel lidel marked this pull request as ready for review December 15, 2021 21:14
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@github-actions
Copy link

This change produced no new differences in built artifacts.

@galargh galargh temporarily deployed to Deploy May 18, 2023 08:16 — with GitHub Actions Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

1 similar comment
@github-actions
Copy link

This change produced no new differences in built artifacts.

@lidel lidel temporarily deployed to Deploy September 20, 2023 15:41 — with GitHub Actions Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

@galargh galargh merged commit f486ab6 into master Sep 20, 2023
6 checks passed
@galargh galargh deleted the fix/bump-ipfs-cat-timeout branch September 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

context deadline exceeded (1m timeout)
3 participants