Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add routing filtering to delegated routing server IPIP-484 #671

Merged
merged 21 commits into from
Sep 27, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Sep 12, 2024

What's in this PR

@2color 2color requested a review from a team as a code owner September 12, 2024 16:04
@2color 2color changed the title feat: add routing filtering to delegated routing IPIP-484 feat: add routing filtering to delegated routing server IPIP-484 Sep 13, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red, so only did a quick first-pass with some feedback inline

routing/http/server/server_test.go Outdated Show resolved Hide resolved
routing/http/server/server_test.go Outdated Show resolved Hide resolved
routing/http/server/server.go Show resolved Hide resolved
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 28 lines in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (628b0f6) to head (137d34f).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
routing/http/server/filters.go 85.58% 12 Missing and 4 partials ⚠️
routing/http/server/server.go 81.25% 6 Missing and 3 partials ⚠️
routing/http/types/iter/filter.go 86.36% 2 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   60.15%   60.36%   +0.21%     
==========================================
  Files         241      243       +2     
  Lines       30712    30889     +177     
==========================================
+ Hits        18475    18647     +172     
- Misses      10582    10587       +5     
  Partials     1655     1655              
Files with missing lines Coverage Δ
routing/http/types/record_peer.go 83.63% <100.00%> (+2.78%) ⬆️
routing/http/types/iter/filter.go 86.36% <86.36%> (ø)
routing/http/server/server.go 72.66% <81.25%> (+0.20%) ⬆️
routing/http/server/filters.go 85.58% <85.58%> (ø)

... and 12 files with indirect coverage changes

@2color 2color requested a review from lidel September 24, 2024 17:17
routing/http/server/filters.go Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
routing/http/server/server.go Show resolved Hide resolved
routing/http/server/server.go Show resolved Hide resolved
routing/http/types/iter/filter.go Show resolved Hide resolved
routing/http/server/filters.go Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in updated ipfs/someguy#82 and LGTM, small suggestions inline, but I think its ok to merge once those are addressed.

CHANGELOG.md Outdated Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
routing/http/server/filters.go Outdated Show resolved Hide resolved
@2color 2color merged commit 4af06fd into main Sep 27, 2024
15 checks passed
@2color 2color deleted the add-protocol-filtering branch September 27, 2024 09:33
@lidel
Copy link
Member

lidel commented Sep 27, 2024

@2color we have pretty good changelog, so not the end of the world, but in future remember to squash PRs like this, to avoid noise in main branch :) (in go repos we prefer squashes)

@2color
Copy link
Member Author

2color commented Sep 27, 2024

Sounds good! Sorry about that. Should we disable merge and rebase commits for this repo then?

@lidel
Copy link
Member

lidel commented Sep 27, 2024

Afraid we need to keep it for the current release process:
https://github.com/ipfs/boxo/blob/main/RELEASE.md#release-process

wenyue pushed a commit to wenyue/boxo that referenced this pull request Oct 17, 2024
@gammazero gammazero mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants