This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
incompatible typescript version - fixes #379 #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silkroadnomad
changed the title
|
CI is for the Angular example passes without these changes so they may not be necessary?
Do you need to update your local lockfile or similar? |
|
Good point! The tests are running through. Tried it on another machine now and got the same error. Maybe the modules are cashed on the Github-CI or so? Because this seems to be a new symptom. 4.7.4 was released only 11 days ago. Is CI cashing older modules of the same minor version? |
|
There's no caching in CI, it just runs a straight |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the ^ from the typescript package because 4.7.4 seems incompatible with the Angular compiler.
This prevented a successful test run with
yarn run testTests are now all running through.