feat(verified-fetch): improve UX #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Feb 7, 2024
| @@ -1,25 +1,182 @@ | |||
| import { useCallback, useState } from 'react' | |||
| // import { verifiedFetch, createVerifiedFetch } from '@helia/verified-fetch' | |||
There was a problem hiding this comment.
when ipfs/helia#423 is merged, we should switch the auto content type button to use the contentTypeParser option.
2color
reviewed
Feb 8, 2024
| const handleVideoType = useCallback(async (resp: Response) => { | ||
| try { | ||
| setLoading('Waiting for full video data...') | ||
| const blob = await resp.blob() |
There was a problem hiding this comment.
At some point, I'd love to dig into streaming the video, but I think we might have to do that in a service worker because there isn't an easy way to just pass a stream into a video element.
2color
approved these changes
Feb 8, 2024
2color
added a commit
that referenced
this pull request
Mar 28, 2024
* feat: add helia/verified-fetch browser example * feat(verified-fetch): improve UX (#286) * Update examples/helia-browser-react-verified-fetch/package.json Co-authored-by: Alex Potsides <[email protected]> * refactor: clean up code and reduce deps * chore: rename folder * chore: add test * chore: fix linting * chore: add test to verified fetch example (#290) * chore: add test to verified fetch example Adds a test for JSON-codec data * chore: test verified fetch during ci * chore: add tests for other types * fix: improve rendering of cids on narrow viewports * fix: improve auto content detection * chore: fix tests * chore: upgrade verified-fetch * feat: add link to the repo * chore: bump verified fetch version * fix: add aborting functionality * fix: handle abort error * feat: add ability to fetch as dag-json * chore: update deps * chore: remove comment * chore: address feedback and simplify code * chore: reduce code duplication and add docs * feat: add links to api docs and source * fix: linting error --------- Co-authored-by: Daniel N <[email protected]> Co-authored-by: Russell Dempsey <[email protected]> Co-authored-by: Alex Potsides <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly modifies the code from #285 to have better UX.
Also implements the previously unimplemented
onFetchImageandonFetchFilefunctions.Better error messaging and loading messages.
Adds
fetch-autofunctionality to attempt to automatically determine content-type for proper rendering.2024-02-07.at.13.58.27.-.Amethyst.Stork.mp4