Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop start feature/attribute as its going away #769

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Drop start feature/attribute as its going away #769

merged 1 commit into from
Dec 21, 2024

Conversation

ipetkov
Copy link
Owner

@ipetkov ipetkov commented Dec 21, 2024

Motivation

Fixes #767

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

@ipetkov ipetkov enabled auto-merge (squash) December 21, 2024 01:19
@ipetkov ipetkov merged commit 769bddf into master Dec 21, 2024
19 checks passed
@ipetkov ipetkov deleted the start branch December 21, 2024 01:22
@kadiwa4
Copy link

kadiwa4 commented Dec 21, 2024

Are you sure that isize is the right type for the argc param and the return value? Usually it would be c_int.

@ipetkov
Copy link
Owner Author

ipetkov commented Dec 21, 2024

IIRC when I checked c_int was an alias for isize. Either way, this doesn't matter too much, the tests are really checking that a custom source (no matter its contents) shows up in the right place, but we aren't really checking that things compile correctly (that's ultimately up to whomever is customizing what the dummy source the want)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heads-up: #[start] is being removed
2 participants