[api] archive-mode for eth_getBalance & eth_call #4529
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| package api | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/iotexproject/go-pkgs/hash" | ||
| "github.com/iotexproject/iotex-address/address" | ||
| "github.com/iotexproject/iotex-proto/golang/iotextypes" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
|
|
||
| "github.com/iotexproject/iotex-core/v2/action" | ||
| accountutil "github.com/iotexproject/iotex-core/v2/action/protocol/account/util" | ||
| "github.com/iotexproject/iotex-core/v2/blockchain/genesis" | ||
| "github.com/iotexproject/iotex-core/v2/pkg/log" | ||
| "github.com/iotexproject/iotex-core/v2/pkg/tracer" | ||
| "github.com/iotexproject/iotex-core/v2/pkg/util/byteutil" | ||
| "github.com/iotexproject/iotex-core/v2/state" | ||
| ) | ||
|
|
||
| type ( | ||
| // CoreServiceReaderWithHeight is an interface for state reader at certain height | ||
| CoreServiceReaderWithHeight interface { | ||
|
There was a problem hiding this comment. could you explain why we need to create such an interface? There was a problem hiding this comment. this interface is created to represent APIs needed for archive-mode query (there will be a total 4-6 of them, 2 enabled in this PR, and more to enable in upcoming PR), so we can keep using existing API without having to add the |
||
| Account(address.Address) (*iotextypes.AccountMeta, *iotextypes.BlockIdentifier, error) | ||
| ReadContract(context.Context, address.Address, action.Envelope) (string, *iotextypes.Receipt, error) | ||
| } | ||
|
|
||
| coreServiceReaderWithHeight struct { | ||
| cs *coreService | ||
| height uint64 | ||
| } | ||
| ) | ||
|
|
||
| func newCoreServiceWithHeight(cs *coreService, height uint64) *coreServiceReaderWithHeight { | ||
| return &coreServiceReaderWithHeight{ | ||
| cs: cs, | ||
| height: height, | ||
| } | ||
| } | ||
|
|
||
| func (core *coreServiceReaderWithHeight) Account(addr address.Address) (*iotextypes.AccountMeta, *iotextypes.BlockIdentifier, error) { | ||
| if !core.cs.archiveSupported { | ||
|
There was a problem hiding this comment. bd7ca1f#diff-699e59a265a0599d1a49698bbf378f57a7aeb60957441a257249102ac8785a8dR50 will return error if archive is not supported |
||
| return nil, nil, ErrArchiveNotSupported | ||
| } | ||
| ctx, span := tracer.NewSpan(context.Background(), "coreServiceReaderWithHeight.Account") | ||
| defer span.End() | ||
| addrStr := addr.String() | ||
| if addrStr == address.RewardingPoolAddr || addrStr == address.StakingBucketPoolAddr { | ||
| return core.cs.getProtocolAccount(ctx, addrStr) | ||
| } | ||
| state, pendingNonce, err := core.stateAndNonce(addr) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| return core.cs.acccount(ctx, core.height, state, pendingNonce, addr) | ||
| } | ||
|
|
||
| func (core *coreServiceReaderWithHeight) stateAndNonce(addr address.Address) (*state.Account, uint64, error) { | ||
| var ( | ||
| g = core.cs.bc.Genesis() | ||
| ctx = genesis.WithGenesisContext(context.Background(), g) | ||
| ) | ||
| ws, err := core.cs.sf.WorkingSetAtHeight(ctx, core.height) | ||
| if err != nil { | ||
| return nil, 0, status.Error(codes.Internal, err.Error()) | ||
| } | ||
| state, err := accountutil.AccountState(ctx, ws, addr) | ||
| if err != nil { | ||
| return nil, 0, status.Error(codes.NotFound, err.Error()) | ||
| } | ||
| var pendingNonce uint64 | ||
| if g.IsSumatra(core.height) { | ||
| pendingNonce = state.PendingNonceConsideringFreshAccount() | ||
| } else { | ||
| pendingNonce = state.PendingNonce() | ||
| } | ||
| return state, pendingNonce, nil | ||
| } | ||
|
|
||
| func (core *coreServiceReaderWithHeight) ReadContract(ctx context.Context, callerAddr address.Address, elp action.Envelope) (string, *iotextypes.Receipt, error) { | ||
| if !core.cs.archiveSupported { | ||
| return "", nil, ErrArchiveNotSupported | ||
| } | ||
| log.Logger("api").Debug("receive read smart contract request") | ||
| exec, ok := elp.Action().(*action.Execution) | ||
| if !ok { | ||
| return "", nil, status.Error(codes.InvalidArgument, "expecting action.Execution") | ||
| } | ||
| var ( | ||
| hdBytes = append(byteutil.Uint64ToBytesBigEndian(core.height), []byte(exec.Contract())...) | ||
| key = hash.Hash160b(append(hdBytes, exec.Data()...)) | ||
| ) | ||
| return core.cs.readContract(ctx, key, core.height, true, callerAddr, elp) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed L261 comment, the name clears explains what the error is