Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Unit Tests for Shanghai Upgrade #3997

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

envestcc
Copy link
Member

@envestcc envestcc commented Nov 24, 2023

Description

Here is the unit testing for the Shanghai upgrade, which includes two parts:

  • backward compatibility verifying
    • select previous test contract cases into shanghai test
  • new features verifying
    • difficulty and prevrandao for eip-4399
    • push0 for eip-3855

The test checking flow requires #3963.

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc force-pushed the pr_shanghaitest branch 2 times, most recently from 6dfcec6 to 5640159 Compare November 24, 2023 03:25
@envestcc envestcc marked this pull request as ready for review November 24, 2023 03:29
@envestcc envestcc requested review from CoderZhi, dustinxie, Liuhaai and a team as code owners November 24, 2023 03:29
@envestcc envestcc mentioned this pull request Nov 24, 2023
6 tasks
@Liuhaai
Copy link
Member

Liuhaai commented Nov 27, 2023

fix failed CI

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 515 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (6806af8) 76.29%.
Report is 125 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 68.49% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
blockindex/sgd_indexer.go 90.30% 12 Missing and 7 partials ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3997      +/-   ##
==========================================
+ Coverage   75.38%   76.29%   +0.91%     
==========================================
  Files         303      330      +27     
  Lines       25923    28247    +2324     
==========================================
+ Hits        19541    21552    +2011     
- Misses       5360     5597     +237     
- Partials     1022     1098      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@envestcc envestcc merged commit 1b9340d into iotexproject:master Dec 7, 2023
4 of 5 checks passed
@envestcc envestcc deleted the pr_shanghaitest branch December 7, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants