-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ioctl): support znode project management commands(based #3987) #3989
Conversation
…otex-core into feat/ioctl_znode_message_query
…/ioctl_znode_project
…ect/iotex-core into feat/ioctl_znode_project
…/ioctl_znode_project
…tex-core into feat/ioctl_znode_project
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3989 +/- ##
==========================================
+ Coverage 75.38% 76.22% +0.84%
==========================================
Files 303 330 +27
Lines 25923 28264 +2341
==========================================
+ Hits 19541 21545 +2004
- Misses 5360 5618 +258
- Partials 1022 1101 +79 ☔ View full report in Codecov by Sentry. |
wsProjectRegisterContractAddress string | ||
wsProjectRegisterContractABI abi.ABI | ||
|
||
//go:embed wsproject.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learned embed
from it!
} | ||
|
||
func convertStringToAbiBytes32(hash string) (interface{}, error) { | ||
t, _ := abi.NewType("bytes32", "", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using [32]byte
is enough
return rsp, nil | ||
} | ||
|
||
func getEventInputsByName(logs []*iotextypes.Log, eventName string) (map[string]any, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's similar to unpackEventParam
in blockindex/contractstaking/util.go, can we make a common util function?
…/ioctl_znode_project
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
support project create, update and query command
Fixes #3982
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: