Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ioctl): add znode commands configs #3986

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

saitofun
Copy link
Contributor

@saitofun saitofun commented Nov 21, 2023

Description

add config for znode commands

Fixes #3982

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 515 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (3317266) 76.23%.
Report is 115 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 44.30% 43 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 68.49% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
action/protocol/execution/evm/evmstatedbadapter.go 0.00% 19 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3986      +/-   ##
==========================================
+ Coverage   75.38%   76.23%   +0.85%     
==========================================
  Files         303      330      +27     
  Lines       25923    28264    +2341     
==========================================
+ Hits        19541    21547    +2006     
- Misses       5360     5617     +257     
- Partials     1022     1100      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saitofun saitofun force-pushed the feat/support_znode_config branch 2 times, most recently from 27f9da0 to cdef48b Compare November 21, 2023 16:42
ioctl/newcmd/config/config.go Outdated Show resolved Hide resolved
ioctl/config/configsetget.go Outdated Show resolved Hide resolved
@saitofun saitofun force-pushed the feat/support_znode_config branch 2 times, most recently from 4b3110a to 960fd68 Compare November 23, 2023 12:49
@saitofun saitofun force-pushed the feat/support_znode_config branch from 960fd68 to 3317266 Compare November 23, 2023 12:52
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.8% 14.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@saitofun saitofun merged commit 3170059 into master Nov 24, 2023
3 of 5 checks passed
@saitofun saitofun deleted the feat/support_znode_config branch November 24, 2023 06:39
CoderZhi added a commit that referenced this pull request Nov 28, 2023
…3989)

* feat(ioctl): add znode commands configs

* feat(ioctl): add znode commands configs

* feat(ioctl): support znode message committing and querying commands(based #3986)

* chore: code fmt

* draft

* feat(ioctl): support ws project mgr commands

* feat(ioctl): support w3bstream message committing and querying commands(based #3986)

* feat(ioctl): ws node project management

* feat(ioctl): ws node project management

* feat(ioctl): ws node project management

* feat(ioctl): ws node project management

* feat(ioctl): ws node project management

* feat(ioctl): ws node project management

* feat(ioctl): ws node project management

---------

Co-authored-by: CoderZhi <[email protected]>
hunshenshi added a commit that referenced this pull request Dec 1, 2023
* feat(ioctl): add znode commands configs

* feat(ioctl): add znode commands configs

* feat(ioctl): support znode message committing and querying commands(based #3986)

* chore: code fmt

* feat(ioctl): support znode code convert(based #3987)

* chore(code): code fmt

* chore(ioctl): del defaultZnodeContractAddress

* chore(ioctl): update comment

* chore(ioctl): split convertCodeToZlibHex

* feat(ioctl): add VmType type

* chore(ioctl): fix ci

---------

Co-authored-by: saito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce wsctl to access w3bstream node
3 participants