Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gasPrice param in estimatedGas API #3985

Merged
merged 5 commits into from
Nov 23, 2023
Merged

support gasPrice param in estimatedGas API #3985

merged 5 commits into from
Nov 23, 2023

Conversation

millken
Copy link
Contributor

@millken millken commented Nov 21, 2023

Description

Add the gasPrice parameter to the estimated gas API to allow passing custom gasPrice to evm

The gRPC part can only be updated after the PR is merged.
iotexproject/iotex-proto#137

Fixes #3984

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 518 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (9076235) 76.11%.
Report is 111 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 44.30% 43 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 67.60% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
action/protocol/execution/evm/evmstatedbadapter.go 0.00% 19 Missing ⚠️
... and 30 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
+ Coverage   75.38%   76.11%   +0.73%     
==========================================
  Files         303      330      +27     
  Lines       25923    28160    +2237     
==========================================
+ Hits        19541    21435    +1894     
- Misses       5360     5621     +261     
- Partials     1022     1104      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@millken millken requested a review from a team as a code owner November 22, 2023 05:21
@millken millken changed the title support gasPrice param in web3 estimatedGas API support gasPrice param in estimatedGas API Nov 22, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@millken millken merged commit b31df43 into iotexproject:master Nov 23, 2023
4 of 5 checks passed
@millken millken deleted the issue3984 branch November 23, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] allow custom gasPrice when estimating gas
3 participants