address comments

iotexproject · Nov 16, 2023 · 3da8930 · 3da8930
1 parent 93ffc32
commit 3da8930
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 11 deletions.
diff --git a/action/protocol/poll/consortium.go b/action/protocol/poll/consortium.go
@@ -155,10 +155,6 @@ func (cc *consortiumCommittee) CreateGenesisStates(ctx context.Context, sm proto
 	ctx = evm.WithHelperCtx(ctx, evm.HelperContext{
 		GetBlockHash: cc.getBlockHash,
 		GetBlockTime: cc.getBlockTime,
-		DepositGasFunc: func(context.Context, protocol.StateManager, address.Address, *big.Int, *big.Int) (*action.TransactionLog, error) {
-			return nil, nil
-		},
-		Sgd: nil,
 	})
 	r := getContractReaderForGenesisStates(ctx, sm)
 	cands, err := cc.readDelegatesWithContractReader(ctx, r)

diff --git a/action/protocol/poll/staking_committee_test.go b/action/protocol/poll/staking_committee_test.go
@@ -141,6 +141,7 @@ func initConstructStakingCommittee(ctrl *gomock.Controller) (Protocol, context.C
 		cfg.Genesis.NativeStakingContractAddress,
 		cfg.Genesis.NativeStakingContractCode,
 		scoreThreshold,
+		func(u uint64) (time.Time, error) { return time.Time{}, nil },
 	)
 
 	return p, ctx, sm, r, err

diff --git a/chainservice/builder.go b/chainservice/builder.go
@@ -622,10 +622,6 @@ func (builder *Builder) registerRollDPoSProtocol() error {
 			}
 
 			// TODO: add depositGas
-			// TODO: replace the fake function with a real one
-			getBlockTime := func(uint64) (time.Time, error) {
-				return time.Time{}, nil
-			}
 			ctx = evm.WithHelperCtx(ctx, evm.HelperContext{
 				GetBlockHash: dao.GetBlockHash,
 				GetBlockTime: getBlockTime,

diff --git a/e2etest/staking_test.go b/e2etest/staking_test.go
@@ -124,9 +124,7 @@ func TestStakingContract(t *testing.T) {
 
 			ctx = evm.WithHelperCtx(ctx, evm.HelperContext{
 				GetBlockHash: dao.GetBlockHash,
-				GetBlockTime: func(u uint64) (time.Time, error) {
-					return time.Time{}, nil
-				},
+				GetBlockTime: fakeGetBlockTime,
 			})
 			data, _, err := sf.SimulateExecution(ctx, addr, ex)